Skip to content

feat: fix integration of scrollview with swipe#1373

Closed
WoLewicki wants to merge 2 commits into
mainfrom
@wolewicki/fix-swipe-with-scrollview
Closed

feat: fix integration of scrollview with swipe#1373
WoLewicki wants to merge 2 commits into
mainfrom
@wolewicki/fix-swipe-with-scrollview

Conversation

@WoLewicki
Copy link
Copy Markdown
Member

@intergalacticspacehighway
Copy link
Copy Markdown
Contributor

@WoLewicki thanks for looking into this!
I am not sure if this PR is related to fixing the swipe gesture with horizontal ScrollView. We have a similar issue over here. I have tried an approach that involves a patch in react native screens to make it work with fullScreenSwipeEnabled prop. Would be awesome if you can review it once. 🙏

@WoLewicki
Copy link
Copy Markdown
Member Author

Could you tell why is this change added: intergalacticspacehighway/pager-view-ios-swipe-back-fix@50d5bb9#diff-3b1c8a26f5b8ec3f2f0d4d96544fec1a102abae599c9212fe308beaa07093172R17 ? As for the rest of the code, I think it can be OK to use it when you have a PageView on the screen, but I am not sure if we would like to merge this code into our repo, especially since you import a view that might not be present if you don't have the lib included: intergalacticspacehighway/pager-view-ios-swipe-back-fix@50d5bb9#diff-3b1c8a26f5b8ec3f2f0d4d96544fec1a102abae599c9212fe308beaa07093172R9

@intergalacticspacehighway
Copy link
Copy Markdown
Contributor

intergalacticspacehighway commented May 4, 2022

@WoLewicki Added some comments in PR. Should've added it earlier, but forgot. Sorry! 😅

P.S: This patch is only needed to support fullScreenSwipeEnabled prop with this behaviour. I think documenting would be better if we can't find a clean solution.

@WoLewicki
Copy link
Copy Markdown
Member Author

Ok, I answered there 🚀

@WoLewicki
Copy link
Copy Markdown
Member Author

Closing since #1512 has been merged.

@WoLewicki WoLewicki closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants