fix: add usage of older API for older iOS versions#1516
Merged
Conversation
gestureRecognizer:shouldReceiveEvent: method However for iOS < 13.4 swiping wont work correctly I guess
kkafar
changed the title
kkafar
changed the title
This method is not necessary if we use both methods from the older API
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gestureRecognizer:shouldReceiveEventmethod is unfortunately available only since iOS 3.14, so I decided to replave it with calls to methods from older apis (9.0+).Changes
gestureRecognizer:shouldReceivePress:&&gestureRecognizer:shouldReceiveTouch:.gestureRecognizer:shouldReceiveEvent:It seems likely to me, that overriding
gestureRecognizer:shouldReceiveTouch:should be enough but basing on apple developer docs - I'm not sure, thus this PR is introducing some dead code (gestureRecognizer:shouldReceivePress:method).Test code and steps to reproduce
Test1072-- see that the behaviour restored in #1512 works also on older iPhones.Checklist