docs: add missing information about status bar props#2953
Conversation
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Is that change coming from edge-to-edge mode being enabled or did we just miss this information in our documentation.
If it is edge-to-edge related change we should state it explicitly, because not all apps use edge-to-edge.
Otherwise this seems fine. I haven't tested the runtime behaviour, assuming you decided to open this PR for a reason.
**Motivation** Recently noticed that docs for `statusBarStyle` and `statusBarHidden` are not kept in sync between files in `react-native-screens` repo, `react-naviagtion` in-code docs and `reactnavigation.org/docs`. I added information about support on Android for `statusBarStyle` and `statusBarHidden` props and `auto` and `inverted` values not being supported on Android for `statusBarStyle`. Similar PR in `react-native-screens`: software-mansion/react-native-screens#2953, `react-navigation.github.io`: react-navigation/react-navigation.github.io#1432.
|
It is just missing docs (it was already updated in When veryfing that these props work, I noticed some problems with |
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I have doubts, whether the reported default values are accurate & also I feel like there is no reason to update /native-stack/ * /src/native-stack. As the whole thing is deprecated anyway.
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Okay, thanks for the links. I'm not approving yet, because I wonder whether we need to introduce this as stable behaviour or not :D I'll approve / reject when I make my mind
kligarski
changed the title
**Motivation** This is a follow-up to #12618 (comment). Changed the in-code docs for `statusBarAnimation` to match [current online docs](https://reactnavigation.org/docs/native-stack-navigator#statusbaranimation). Similar PR in `react-native-screens`: software-mansion/react-native-screens#2953.
2 participants
Description
Add information about supported values for
statusBarStyleandstatusBarAnimation.Similar PR in
react-navigation: react-navigation/react-navigation#12618,react-navigation.github.io: react-navigation/react-navigation.github.io#1432.Changes
autoandinvertednot being supported forstatusBarStyleon Androidlightbeing default value forstatusBarStyleon AndroidstatusBarAnimationdefault values and differences in behavior between Android and iOSChecklist