Conversation
FeatureFlags exportsFeatureFlags exports
| }, | ||
| }; | ||
|
|
||
| export default featureFlags; |
There was a problem hiding this comment.
it's breaking change from the perspective of public API, the code looks good, but we shouldn't merge this PR to main as long as we're publishing 4.x from main
There was a problem hiding this comment.
Maybe you're right actually. TBH I'm no longer sure myself. We need to define in readme what is the public API - only things exported directly from react-native-screens.
kkafar
left a comment
There was a problem hiding this comment.
Looks good. I classified this as a breaking change for some reason in the ticket description. Before merging, could you take a look at how Expo & react-navigation uses it. I'm sure that Expo does, react-navigation might not use the feature flags, but not sure.
Please check whether this change will break them or not.
Please keep in mind that feature flags can be used inside end-users' apps, not only downstream libs |
Description
This PR deduplicates
featureFlagsexports.Closes https://github.com/software-mansion/react-native-screens-labs/issues/699
Changes
flags.tsfeatureFlagsimportsBefore & after - visual documentation
N/A
Test plan
Checklist