Skip to content

fix(android): Remove subview from previous parent before adding to toolbar in ScreenStackHeaderConfig #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
l2hyunwoo wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Draft

fix(android): Remove subview from previous parent before adding to toolbar in ScreenStackHeaderConfig #3777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.text.TextUtils
import android.util.TypedValue
import android.view.Gravity
import android.view.View.OnClickListener
import android.view.ViewGroup
import android.widget.ImageView
import android.widget.TextView
import androidx.appcompat.app.AppCompatActivity
Expand Down Expand Up @@ -338,6 +339,7 @@ class ScreenStackHeaderConfig(
else -> {}
}
view.layoutParams = params
(view.parent as? ViewGroup)?.removeView(view)
toolbar.addView(view)
i++
}
Expand Down