Skip to content

fix(Android, Stack): dispatch lifecycle events when parent is not a ScreenFragment #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkafar merged 2 commits into from
Apr 15, 2026
+3 −1
Merged

fix(Android, Stack): dispatch lifecycle events when parent is not a ScreenFragment #3854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e95b46
fix(Android, Stack): dispatch lifecycle events when parent is not a S…
collectioneur Apr 8, 2026
65aeb5b
Simplify the condition just a bit
kkafar Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/src/main/java/com/swmansion/rnscreens/ScreenFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,10 @@ open class ScreenFragment :
// since we subscribe to parent's animation start/end and dispatch events in child from there
// check for `isTransitioning` should be enough since the child's animation should take only
// 20ms due to always being `StackAnimation.NONE` when nested stack being pushed
// When the parent is not a ScreenFragment (e.g. when RN is loaded inside a ReactFragment
// in a brownfield setup), we always dispatch. Such parents don't participate in screen transitions.
val parent = parentFragment
if (parent == null || (parent is ScreenFragment && !parent.isTransitioning)) {
if (parent == null || parent !is ScreenFragment || !parent.isTransitioning) {
// onViewAnimationStart/End is triggered from View#onAnimationStart/End method of the fragment's root
// view. We override an appropriate method of the StackFragment's
// root view in order to achieve this.
Expand Down
Loading