chore(test): add e2e tests for tabs bottomAccessory on iOS#3976
Open
LKuchno wants to merge 29 commits into
Open
chore(test): add e2e tests for tabs bottomAccessory on iOS#3976LKuchno wants to merge 29 commits into
LKuchno wants to merge 29 commits into
Conversation
…ns into @lkuchno/test-tab-bottom-accessory
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
…are-mansion/react-native-screens into @lkuchno/e2e-test-tab-bottom-accessory-ios
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an iOS-only Detox e2e suite and a dedicated single-feature-test scenario screen to validate TabsHost’s bottomAccessory behavior (including persistence across tabs and transitions between extended vs inline layouts driven by tabBarMinimizeBehavior).
Changes:
- Added a new iOS Detox suite covering accessory rendering, variant switching, persistence across tab changes, and scroll-driven layout transitions.
- Replaced the old placeholder scenario with a new instrumented 3-tab scenario screen (Config / ScrollDown / ScrollUp) and added
testIDs needed for reliable Detox selectors. - Updated tabs scenario registration to point to the new scenario module and added a written manual test plan (
scenario.md).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-ios.e2e.ts | New iOS Detox suite exercising bottom accessory variants, persistence, and scroll-driven layout transitions. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/scenario.md | Documents manual + automated coverage and iPad-specific notes. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/index.tsx | New 3-tab test scenario screen with runtime host-config updates and testIDs for e2e. |
| apps/src/tests/single-feature-tests/tabs/index.ts | Registers the new scenario module in the Tabs single-feature-tests group. |
| apps/src/tests/single-feature-tests/tabs/bottom-accessory-layout.tsx | Removes the previous placeholder scenario implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
Collaborator
Author
|
Problem with not collapsing tab bar (tabBarMinimizeBehavior) which lead to TestiOS e2e failure is fixed when changes from this PR are applied: |
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds automated Detox e2e test coverage for the
bottomAccessoryprop onTabsHost(iOS-only, requires iOS 26+). The new Detox suite (test-tabs-bottom-accessory-ios.e2e.ts) covers initial render, variant switching, accessory persistence across tab changes, and the extended-to-inline layout transition driven by scroll direction. Ascenario.mdwas updated in e2e section wth information what was automated and what wasn't.Changes
test-tabs-bottom-accessory-ios.e2e.ts- a Detox iOS-only suite with test cases covering accessory render, variant updates, cross-tab persistence, and scroll-driven layout transitions (extended↔inline)test-tabs-bottom-accessory-layout-ios/directory; addtestIDprops to all accessory views, variant cards, and scroll items; addScrollDownTabandScrollUpTabcomponents; auto-scrollScrollUpTabto bottom on mount so the scroll-up direction is meaningful for minimize behavior testingscenario.mdwith e2e automation info