Skip to content

chore(test): add e2e tests for tabs bottomAccessory on iOS#3976

Open
LKuchno wants to merge 29 commits into
mainfrom
@lkuchno/e2e-test-tab-bottom-accessory-ios
Open

chore(test): add e2e tests for tabs bottomAccessory on iOS#3976
LKuchno wants to merge 29 commits into
mainfrom
@lkuchno/e2e-test-tab-bottom-accessory-ios

Conversation

@LKuchno
Copy link
Copy Markdown
Collaborator

@LKuchno LKuchno commented May 6, 2026

Description

This PR adds automated Detox e2e test coverage for the bottomAccessory prop on TabsHost (iOS-only, requires iOS 26+). The new Detox suite (test-tabs-bottom-accessory-ios.e2e.ts) covers initial render, variant switching, accessory persistence across tab changes, and the extended-to-inline layout transition driven by scroll direction. A scenario.md was updated in e2e section wth information what was automated and what wasn't.

Changes

  • FabricExample/e2e: Add test-tabs-bottom-accessory-ios.e2e.ts - a Detox iOS-only suite with test cases covering accessory render, variant updates, cross-tab persistence, and scroll-driven layout transitions (extendedinline)
  • apps/tests/tabs: Restructured test-tabs-bottom-accessory-layout-ios/ directory; add testID props to all accessory views, variant cards, and scroll items; add ScrollDownTab and ScrollUpTab components; auto-scroll ScrollUpTab to bottom on mount so the scroll-up direction is meaningful for minimize behavior testing
  • apps/tests/tabs: Update scenario.md with e2e automation info

@LKuchno LKuchno changed the title feat(test): add e2e tests for tabs bottomAccessory on iOS chore(test): add e2e tests for tabs bottomAccessory on iOS May 6, 2026
@LKuchno LKuchno requested a review from Copilot May 6, 2026 09:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an iOS-only Detox e2e suite and a dedicated single-feature-test scenario screen to validate TabsHost’s bottomAccessory behavior (including persistence across tabs and transitions between extended vs inline layouts driven by tabBarMinimizeBehavior).

Changes:

  • Added a new iOS Detox suite covering accessory rendering, variant switching, persistence across tab changes, and scroll-driven layout transitions.
  • Replaced the old placeholder scenario with a new instrumented 3-tab scenario screen (Config / ScrollDown / ScrollUp) and added testIDs needed for reliable Detox selectors.
  • Updated tabs scenario registration to point to the new scenario module and added a written manual test plan (scenario.md).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-ios.e2e.ts New iOS Detox suite exercising bottom accessory variants, persistence, and scroll-driven layout transitions.
apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/scenario.md Documents manual + automated coverage and iPad-specific notes.
apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/index.tsx New 3-tab test scenario screen with runtime host-config updates and testIDs for e2e.
apps/src/tests/single-feature-tests/tabs/index.ts Registers the new scenario module in the Tabs single-feature-tests group.
apps/src/tests/single-feature-tests/tabs/bottom-accessory-layout.tsx Removes the previous placeholder scenario implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-ios.e2e.ts Outdated
LKuchno and others added 2 commits May 6, 2026 11:08
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@LKuchno LKuchno requested a review from kmichalikk May 6, 2026 09:10
@LKuchno
Copy link
Copy Markdown
Collaborator Author

LKuchno commented May 11, 2026

Problem with not collapsing tab bar (tabBarMinimizeBehavior) which lead to TestiOS e2e failure is fixed when changes from this PR are applied:
https://github.com/software-mansion/react-native-screens/pull/4004/changes
image

…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
@LKuchno LKuchno added area:tabs Issue related to bottom tabs type:e2e Actions related to e2e maintenance and development, especially automation. labels May 12, 2026
LKuchno and others added 2 commits May 13, 2026 11:22
…ns into @lkuchno/e2e-test-tab-bottom-accessory-ios
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tabs Issue related to bottom tabs type:e2e Actions related to e2e maintenance and development, especially automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants