chore: use target_compile_definitions instead of appending to CMAKE_CXX_FLAGS#2713
Merged
Conversation
tomekzaw
approved these changes
Jul 14, 2025
jakex7
changed the title
target_compile_definitions instead of appending to CMAKE_CXX_FLAGS
jakex7
force-pushed
the
@jakex7/useTargetCompileDefinitions
branch
from
57a82b6 to
6a696d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
target_compile_definitionsinstead of appending toCMAKE_CXX_FLAGS