fix: add xmlns and xmlnsXlink to SvgProps types (#1638)#2982
Open
patrickwehbe wants to merge 1 commit into
Open
fix: add xmlns and xmlnsXlink to SvgProps types (#1638)#2982patrickwehbe wants to merge 1 commit into
patrickwehbe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1638.
Using
xmlns(andxmlnsXlink) on<Svg>raises a TypeScript error:This is the standard output of SVGO and most web/SVG export tools, so people
who paste an optimized SVG component hit the error immediately:
SvgPropsalready accepts other root-only attributes likeviewBoxandpreserveAspectRatio, but not the namespace attributes. This adds them asoptional strings. They are inert in the native renderer (no behavior change),
so this is purely a type-surface fix that lets the standard exported markup
type-check.
Test Plan
<Svg xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink" />fails
yarn tscbefore this change and passes after.yarn tscpassesyarn lintpassesCompatibility
Type-only change; no platform code affected.
Checklist
README.md__tests__folder