[ts-sdk] Add VP8 and VP9 to RTMP output#2011
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Enhanced RTMP (E-RTMP) codec options to the TypeScript SDK surface area so RTMP client outputs can be configured with VP8/VP9 video and Opus audio, aligning TS types and request-mapping with the backend API.
Changes:
- Extend TS output option types for RTMP client outputs to include
ffmpeg_vp8,ffmpeg_vp9, andopus. - Update
smelter-coreRTMP output request mapping to serialize the new encoder variants into the API (snake_case) shape. - Refresh OpenAPI / Rust schema documentation for bitrate description formatting and examples.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/smelter/src/types/output/rtmp.ts | Adds new RTMP encoder variants to the public TS SDK types. |
| ts/smelter/src/api.generated.ts | Regenerates API types to include the new RTMP encoder unions. |
| ts/smelter-core/src/api/output/rtmp.ts | Extends RTMP encoder-to-API mapping to handle VP8/VP9 and Opus. |
| tools/schemas/openapi_specification.json | Updates bitrate description text formatting (adds example line break). |
| smelter-api/src/output/rtmp.rs | Updates Rust/OpenAPI docs for VP8/VP9 bitrate description example text. |
Comments suppressed due to low confidence (2)
ts/smelter/src/types/output/rtmp.ts:64
- The new
ffmpeg_vp9RTMP encoder option is missing the API note that it requires Enhanced RTMP support on the receiver side. Please add the same warning as in the OpenAPI/Rust schema so TS SDK users understand compatibility constraints.
type: 'ffmpeg_vp9';
/**
* Encoding bitrate. If not provided, bitrate is calculated based on resolution and framerate.
* For example at 1080p 30 FPS the average bitrate is 5000 kbit/s and max bitrate is 6250 kbit/s.
*/
ts/smelter-core/src/api/output/rtmp.ts:101
intoRtmpClientAudioEncoderOptionshas nodefaultbranch / fallback after theswitch, so an unexpectedencoder.typewould make this function returnundefinedat runtime. Add an explicitdefaultthat throws a clear error (or anassertUnreachable) to avoid hard-to-debug failures downstream.
sample_rate: encoder.sampleRate,
};
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3d12e11 to
d071724
Compare
wkozyra95
approved these changes
May 22, 2026
ts-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.