fix SAM-EM Other Incentives handling. WIP to adjust Other Incentives to be output after OCC

Author: softwareengineerprogrammer

src/geophires_x/Economics.py

@@ -3455,7 +3455,14 @@ def calculate_total_capital_costs(self, model: Model) -> None:
             self.CCap.value = self.CCap.value - self.RITCValue.value
 
         # Add in the FlatLicenseEtc, OtherIncentives, & TotalGrant
-        self.CCap.value = self.CCap.value + self.FlatLicenseEtc.value - self.OtherIncentives.value - self.TotalGrant.value
+        # Add in the FlatLicenseEtc, OtherIncentives, & TotalGrant
+        if self.econmodel.value != EconomicModel.SAM_SINGLE_OWNER_PPA:
+            self.CCap.value = (
+                    self.CCap.value
+                    + self.FlatLicenseEtc.value
+                    - self.OtherIncentives.value
+                    - self.TotalGrant.value
+            )
 
     def calculate_operating_and_maintenance_costs(self, model: Model) -> None:
         # O&M costs

src/geophires_x/EconomicsSam.py

@@ -238,7 +238,16 @@ def sf(_v: float, num_sig_figs: int = 5) -> float:
     sam_economics.after_tax_irr.value = sf(_get_after_tax_irr_pct(single_owner, cash_flow_operational_years, model))
 
     sam_economics.project_npv.value = sf(_get_project_npv_musd(single_owner, cash_flow_operational_years, model))
-    sam_economics.capex.value = single_owner.Outputs.adjusted_installed_cost * 1e-6
+    # Add back ibi_oth_amount (OtherIncentives + TotalGrant) which SAM subtracts from
+    # total_installed_cost to compute adjusted_installed_cost. Incentives are still applied
+    # by SAM natively in the cash flow / tax basis calculations; we just don't want them to
+    # also reduce the reported Total CAPEX (which would be inconsistent with Overnight Capital
+    # Cost, since CCap is no longer reduced by incentives for SAM Economic Models -- see
+    # Economics.calculate_capital_costs).
+    _ibi_oth_usd = (
+        (model.economics.OtherIncentives.quantity() + model.economics.TotalGrant.quantity()).to('USD').magnitude
+    )
+    sam_economics.capex.value = (single_owner.Outputs.adjusted_installed_cost + _ibi_oth_usd) * 1e-6
 
     if model.economics.has_royalties:
         combined_royalties_usd = [

src/geophires_x/Outputs.py

@@ -531,7 +531,7 @@ def PrintOutputs(self, model: Model):
 
                 additional_capex_modifiers: list[tuple[Parameter, int]] = [
                     (econ.FlatLicenseEtc, 1),
-                    (econ.OtherIncentives, -1),
+                    (econ.OtherIncentives, -1),  # FIXME WIP display after OCC instead of before
                     (econ.TotalGrant, -1)
                 ]
                 for additional_capex_modifier_entry in additional_capex_modifiers:

tests/geophires_x_tests/other-incentives-and-one-time-flat-fees.txt

@@ -0,0 +1,98 @@
+# *** ECONOMIC/FINANCIAL PARAMETERS ***
+# *************************************
+
+Economic Model, 5, -- SAM Single Owner PPA
+
+Starting Electricity Sale Price, 0.12
+Electricity Escalation Rate Per Year, 0.00057
+Ending Electricity Sale Price, 0.16
+Electricity Escalation Start Year, 1
+
+Discount Rate, 0.12
+Royalty Holder Discount Rate, 0.10
+
+Fraction of Investment in Bonds, 0.85
+Inflated Bond Interest Rate, 0.07
+
+Inflation Rate, 0.027
+
+Construction Years, 2
+Construction CAPEX Schedule, 0.01,0.01,0.03,0.05,0.2,0.3,0.4
+Inflated Bond Interest Rate During Construction, 0.105
+
+Investment Tax Credit Rate, 0.3
+Property Tax Rate, 0.0055
+Other Incentives, 5, -- Triggers the double-counting bug in combination with SAM-EM
+One-time Flat License Fees Etc, 1.5
+
+Capital Cost for Power Plant for Electricity Generation, 2000
+Field Gathering System Capital Cost Adjustment Factor, 0.54
+
+Reservoir Stimulation Capital Cost per Injection Well, 0
+# Production wells are not stimulated (parameter intentionally omitted)
+
+# *** SURFACE & SUBSURFACE TECHNICAL PARAMETERS ***
+# *************************************************
+
+End-Use Option, 1, -- Electricity
+Power Plant Type, 2, -- Supercritical ORC
+Plant Lifetime, 20
+
+Injectivity Index, 12.8
+Productivity Index, 4.6
+
+Reservoir Model, 4, -- ANNUAL_PERCENTAGE
+Drawdown Parameter Schedule, 0.003,0.001,0.0 * 10,0.001 * 3,0.002 * 3,0.003 * 3,0.004 * 3,0.005 * 4,0.006
+
+Maximum Drawdown, 1
+
+Reservoir Volume Option, 1, -- FRAC_NUM_SEP (geometry used to size HSA volume; no real fractures)
+Number of Fractures per Stimulated Well, 1
+Fracture Shape, 4, -- RECTANGULAR
+Fracture Width, 3300
+Fracture Height, 40
+Fracture Separation, 960
+
+Production Flow Rate per Well, 107
+
+Number of Injection Wells per Production Well, 0.75
+
+Production Well Diameter, 8.535
+Injection Well Diameter, 8.535
+
+Ramey Production Wellbore Model, True
+Injection Temperature, 50
+
+Water Loss Fraction, 0.05
+
+Utilization Factor, 0.913
+Plant Outlet Pressure, 9.65 bar
+Production Wellhead Pressure, 10.34 bar
+Circulation Pump Efficiency, 0.80
+
+Well Geometry Configuration, 4, -- L: Vertical section plus lateral(s)
+
+Number of Production Wells, 8
+Number of Multilateral Sections, 8
+Nonvertical Length per Multilateral Section, 1600
+All-in Nonvertical Drilling Costs, 2053.9081603055893
+Combined Income Tax Rate, 0.2448
+Well Drilling Cost Correlation, 16
+Royalty Rate Schedule, 0.08
+Bond Financing Start Year, -1
+
+# *** SCENARIO-SPECIFIC RESERVOIR PARAMETERS ***
+# **********************************************
+Gradient 1, 43.4
+Reservoir Depth, 2.8
+Surface Temperature, 10.5
+Ambient Temperature, 3.0
+Reservoir Heat Capacity, 1200.0
+Reservoir Density, 2500.0
+Reservoir Thermal Conductivity, 3.0
+Reservoir Porosity, 0.17
+
+# *** SIMULATION PARAMETERS ***
+# *****************************
+Time steps per year, 12
+Print Output to Console, 0

tests/geophires_x_tests/test_economics_sam.py

@@ -1423,6 +1423,18 @@ def _itc_output_q(r: GeophiresXResult) -> dict[str, float]:
             _itc_output_q(r_fed_itc_rate_and_state_itc_amount),
         )
 
+    def test_other_incentives_and_one_time_flat_fees(self):
+        r: GeophiresXResult = GeophiresXClient().get_geophires_result(
+            ImmutableGeophiresInputParameters(
+                from_file_path=self._get_test_file_path('other-incentives-and-one-time-flat-fees.txt'),
+            )
+        )
+
+        self.assertGreater(
+            r.result['CAPITAL COSTS (M$)']['Total CAPEX']['value'],
+            r.result['CAPITAL COSTS (M$)']['Overnight Capital Cost']['value'],
+        )
+
     @staticmethod
     def _new_model(
         input_file: Path,