This repository was archived by the owner on Apr 27, 2023. It is now read-only.
Adding the possibility to not pull changes for repositories for a given period and fix readme#76
Merged
Merged
Conversation
…en period (especially during the night) as well as fixing README for running the H2 console from sbt.
|
|
||
| lazy val invitationExpiryTime: ReadablePeriod = Period.millis(getMilliseconds("codebrag.invitation-expiry-time", 24.hours.toMillis).toInt) | ||
|
|
||
| lazy val pullSleepPeriodEnabled = getBoolean("codebrag.pull-sleep-period.enabled", default = true) |
Member
There was a problem hiding this comment.
What about using false by default? Thus will keep backward comaptibility
|
|
||
| trait EmailNotificationConfig extends ConfigWithDefault { | ||
| lazy val userNotifications: Boolean = getBoolean("email-notifications.enabled", default = true) | ||
| lazy val userNotifications: Boolean = getBoolean("email-notifications.enabled", default = false) |
Member
There was a problem hiding this comment.
Why did you switch this to false?
Contributor
Author
There was a problem hiding this comment.
Sorry, this is a mistake. Il altered the wrong line. I will push it back with true.
Member
|
No more comments from my side, great work! 👍 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to save network bandwith as well as uneeded logs, the configuration of Codebrag gets enriched with a new parameter store in the
codebragblock. This parameter is of the following form:This configuration says that Codebrag is allowed to not pull changes for repositories from 10PM to 4:59AM. If
enabledis set tofalsethen Codebrag will always pull changes.This PR also fixes an error in the
README.md: in order to run the H2 console fromsbtwe must callcodebrag-dao/runH2Consoleand notcodebrag-dao/run-h2-console.