Add internal resistors to 3-phase decoupling ITM,

Signed-off-by: pipeacosta <pipeacosta@gmail.com>

Author: pipeacosta

dpsim-models/include/dpsim-models/Signal/DecouplingIdealTransformer_EMT_Ph3.h

@@ -12,6 +12,7 @@
 
 #include "dpsim-models/Definitions.h"
 #include "dpsim-models/EMT/EMT_Ph3_ControlledVoltageSource.h"
+#include "dpsim-models/MathUtils.h"
 #include <dpsim-models/EMT/EMT_Ph3_ControlledCurrentSource.h>
 #include <dpsim-models/EMT/EMT_Ph3_Resistor.h>
 #include <dpsim-models/SimSignalComp.h>
@@ -25,7 +26,13 @@ class DecouplingIdealTransformer_EMT_Ph3
       public SharedFactory<DecouplingIdealTransformer_EMT_Ph3> {
 protected:
   Real mDelay;
-  std::shared_ptr<EMT::SimNode> mNode1, mNode2;
+  Matrix mInternalSeriesResistance =
+      CPS::Math::singlePhaseParameterToThreePhase(1e-6);
+  Matrix mInternalParallelResistance =
+      CPS::Math::singlePhaseParameterToThreePhase(1e6);
+
+  std::shared_ptr<EMT::SimNode> mNode1, mNode2, mVirtualNode;
+  std::shared_ptr<EMT::Ph3::Resistor> mRes1, mRes2;
   std::shared_ptr<EMT::Ph3::ControlledCurrentSource> mCurrentSrc;
   std::shared_ptr<EMT::Ph3::ControlledVoltageSource> mVoltageSrc;
   Attribute<Matrix>::Ptr mSrcCurrent, mSrcVoltage;
@@ -73,6 +80,7 @@ class DecouplingIdealTransformer_EMT_Ph3
   void postStep();
   Task::List getTasks();
   IdentifiedObject::List getComponents();
+  TopologicalNode::Ptr getVirtualNode();
 
   class PreStep : public Task {
   public:

dpsim-models/src/Signal/DecouplingIdealTransformer_EMT_Ph3.cpp

@@ -7,6 +7,7 @@
  *********************************************************************************/
 
 #include "dpsim-models/Definitions.h"
+#include "dpsim-models/TopologicalNode.h"
 #include <dpsim-models/Signal/DecouplingIdealTransformer_EMT_Ph3.h>
 
 using namespace CPS;
@@ -24,6 +25,8 @@ DecouplingIdealTransformer_EMT_Ph3::DecouplingIdealTransformer_EMT_Ph3(
       mSrcVoltageRef(mAttributes->create<Matrix>("v_ref", Matrix::Zero(3, 1))),
       mSrcCurrentRef(mAttributes->create<Matrix>("i_ref", Matrix::Zero(3, 1))) {
 
+  mRes1 = Resistor::make(name + "_r1", logLevel);
+  mRes2 = Resistor::make(name + "_r2", logLevel);
   mVoltageSrc = ControlledVoltageSource::make(name + "_v", logLevel);
   mCurrentSrc = ControlledCurrentSource::make(name + "_i", logLevel);
 
@@ -37,6 +40,7 @@ void DecouplingIdealTransformer_EMT_Ph3::setParameters(
 
   mNode1 = node1;
   mNode2 = node2;
+  mVirtualNode = SimNode<Real>::make(name() + "_virtual", PhaseType::ABC);
 
   mDelay = delay;
   mCouplingMethod = method;
@@ -45,10 +49,14 @@ void DecouplingIdealTransformer_EMT_Ph3::setParameters(
     mExtrapolationDegree = 1;
   }
 
+  mRes1->setParameters(mInternalSeriesResistance);
+  mRes1->connect({node1, mVirtualNode});
+  mRes2->setParameters(mInternalParallelResistance);
+  mRes2->connect({node2, SimNode<Real>::GND});
   mVoltageSrc->setParameters(Matrix::Zero(3, 1));
   mVoltageSrcIntfCurr = voltageSrcIntfCurr;
   mCurrent1Extrap0 = current1Extrap0;
-  mVoltageSrc->connect({SimNode<Real>::GND, node1});
+  mVoltageSrc->connect({SimNode<Real>::GND, mVirtualNode});
   mCurrentSrc->setParameters(Matrix::Zero(3, 1));
   mCurrentSrc->connect({node2, SimNode<Real>::GND});
 }
@@ -68,6 +76,9 @@ void DecouplingIdealTransformer_EMT_Ph3::initialize(Real omega, Real timeStep) {
   MatrixComp cur1 = mVoltageSrc->mIntfCurrent->get();
   MatrixComp volt2 = mNode2->initialVoltage();
 
+  mVirtualNode->setInitialVoltage(mNode1->initialVoltage() -
+                                  mInternalSeriesResistance * cur1);
+
   SPDLOG_LOGGER_INFO(mSLog, "initial current: i_1 {}", cur1);
   SPDLOG_LOGGER_INFO(mSLog, "initial voltage: v_2 {}", volt2);
 
@@ -176,5 +187,9 @@ Task::List DecouplingIdealTransformer_EMT_Ph3::getTasks() {
 }
 
 IdentifiedObject::List DecouplingIdealTransformer_EMT_Ph3::getComponents() {
-  return IdentifiedObject::List({mVoltageSrc, mCurrentSrc});
+  return IdentifiedObject::List({mRes1, mRes2, mVoltageSrc, mCurrentSrc});
+}
+
+TopologicalNode::Ptr DecouplingIdealTransformer_EMT_Ph3::getVirtualNode() {
+  return mVirtualNode;
 }

dpsim/examples/cxx/Circuits/EMT_RC_split_decoupled_node_Ph3.cpp

@@ -109,6 +109,7 @@ void decoupleNode(SystemTopology &sys, const String &nodeName,
                             i_inf_0, cosimMethod);
   sys.addComponent(idealTrafo);
   sys.addComponents(idealTrafo->getComponents());
+  sys.addNode(idealTrafo->getVirtualNode());
 }
 
 void doSim(String &name, SystemTopology &sys, Int threads, Real ts,

dpsim/src/pybind/SignalComponents.cpp

@@ -99,7 +99,9 @@ void addSignalComponents(py::module_ mSignal) {
            "node_1"_a, "node_2"_a, "delay"_a, "v_src_intf_cur"_a,
            "cur1_extrap_0"_a, "coupling_method"_a)
       .def("get_components",
-           &CPS::Signal::DecouplingIdealTransformer_EMT_Ph3::getComponents);
+           &CPS::Signal::DecouplingIdealTransformer_EMT_Ph3::getComponents)
+      .def("get_virtual_node",
+           &CPS::Signal::DecouplingIdealTransformer_EMT_Ph3::getVirtualNode);
 
   py::class_<CPS::Signal::Exciter, std::shared_ptr<CPS::Signal::Exciter>,
              CPS::SimSignalComp>(mSignal, "Exciter", py::multiple_inheritance())

examples/Notebooks/Components/ITM.ipynb

@@ -112,6 +112,7 @@
     "\n",
     "sys = dpsimpy.SystemTopology(f_1, [n0, n1_1, n1_2, n2], [vs, R_1, line, itm, load])\n",
     "sys.add(itm.get_components())\n",
+    "sys.add_node(itm.get_virtual_node())\n",
     "\n",
     "logger = dpsimpy.Logger(sim_name)\n",
     "logger.log_attribute(\"v1_1\", \"v\", n1_1)\n",
@@ -124,11 +125,12 @@
     "logger.log_attribute(\"v_intf_itm\", \"v_intf\", itm)\n",
     "logger.log_attribute(\"iload\", \"i_intf\", load)\n",
     "\n",
-    "sim = dpsimpy.Simulation(sim_name)\n",
+    "sim = dpsimpy.Simulation(sim_name, dpsimpy.LogLevel.debug)\n",
     "sim.set_system(sys)\n",
     "sim.set_time_step(time_step)\n",
     "sim.set_final_time(final_time)\n",
     "sim.set_domain(dpsimpy.Domain.EMT)\n",
+    "sim.do_split_subnets(True)\n",
     "sim.add_logger(logger)\n",
     "\n",
     "sim.run()"

examples/Notebooks/Performance/EMT_RC_split_node_Ph3.ipynb

@@ -16,7 +16,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 1,
+   "execution_count": null,
    "metadata": {},
    "outputs": [],
    "source": [