Feature: New exciter models by leonardocarreras · Pull Request #402 · sogno-platform/dpsim

leonardocarreras · 2025-08-29T18:06:29Z

This is based on various PRs from @martinmoraga at the times of his work on ACS.

Adaptations are mine.

Ongoing work.

New models:

Add Model: Exciter DC1
Add Model: Exciter DC1 Simplified > Replaces old Exciter (.h & .cpp)
Add Model: Exciter DC1 Simplified for sT1
Add Model: Exciter DC1 Static

Updates

Add Base Exciter model
Add models to Factory
Add models to Component list
Update Generator models to the new Exciters
Keep a deprecated interface for backwards compatibility in generators
Update existing C++ examples
Update python bindings
Update notebook examples
Add documentation

Other

Fix logger (fmt related) for handling new exciter

leonardocarreras · 2026-06-04T23:47:49Z

Hi @georgii-tishenin @pipeacosta, I know this is not a small PR. Let me know if it is possible to have a look, or if we need to do it differently. Thanks in advance.

codecov · 2026-06-05T00:20:05Z

Codecov Report

❌ Patch coverage is 64.84211% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.86%. Comparing base (2e3f952) to head (4a5f757).

Files with missing lines	Patch %	Lines
dpsim-models/src/Signal/ExciterDC1.cpp	39.72%	44 Missing ⚠️
...ls/src/Base/Base_ReducedOrderSynchronGenerator.cpp	6.06%	31 Missing ⚠️
dpsim-models/src/Signal/ExciterStatic.cpp	50.00%	26 Missing ⚠️
dpsim-models/src/Signal/ExciterDC1Simp.cpp	76.56%	15 Missing ⚠️
dpsim/src/pybind/BaseComponents.cpp	53.33%	14 Missing ⚠️
dpsim-models/src/Signal/ExciterST1Simp.cpp	60.00%	12 Missing ⚠️
dpsim/src/pybind/SignalComponents.cpp	86.36%	12 Missing ⚠️
dpsim-models/include/dpsim-models/Factory.h	0.00%	8 Missing ⚠️
dpsim-models/include/dpsim-models/Logger.h	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   66.03%   65.86%   -0.17%     
==========================================
  Files         401      405       +4     
  Lines       24303    24684     +381     
  Branches    12332    12494     +162     
==========================================
+ Hits        16048    16259     +211     
- Misses       8254     8424     +170     
  Partials        1        1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

georgii-tishenin

Thanks for the PR. I especially like that the new exciter models are added together with documentation and Python bindings.

I left a few small comments/questions. I do not see this as a strict requirement for this PR, but it would give a better feeling to have tests/examples covering all new exciter models.

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

georgii-tishenin

Thanks for addressing the comments!

@martinmoraga

…ython bindings (#490) ## Summary Connects `Signal::TurbineGovernorType1` (the Milano 2010 governor + servo + reheat model) to the generator base classes, following the same pattern as the exciter #402 and PSS #486 PRs. - Added `addGovernor(shared_ptr<TurbineGovernorType1>)` to both `Base_SynchronGenerator` and `Base_ReducedOrderSynchronGenerator`, with a null guard; the old scalar `addGovernor(Ta, Tb, …)` now logs a deprecation warning - `EMT_Ph3_SynchronGeneratorDQTrapez` and `EMT_Ph3_SynchronGeneratorVBR` use the new path when a `TurbineGovernorType1` is attached, falling back to the legacy `TurbineGovernor` otherwise - Python bindings for `initialize()` and `add_governor()` on both ReducedOrder generator variants - Hardened the model: zero-division guards in `setParameters()`, `_prev` variables initialised in `initialize()`, state variables moved to `private:` - Docs: added the Turbine Governor Type 1 section with block diagram and equations; fixed an upstream bug where the discrete τ_m equation referenced T3 instead of T5 ## What comes next - `TurbineGovernorType1` bundles governor, servo, and reheat into a single class, so it fits naturally into the existing `addGovernor()` hook without needing new abstractions. - The next PR introduces `Base::Governor` and `Base::Turbine` together with the first models that actually split those two concerns: a steam governor and a steam turbine as separate, chainable objects. The separation matters because different turbine types (steam, hydro) share the same governor interface, so it makes sense to model them independently rather than bundling everything together as done here. - A final PR then adds the hydro variants, which reuse the same base classes and generator hooks without any further infrastructure changes. ### Other comments This is the continuation of what was part of the controllers work from @martinmoraga at ACS.

@martinmoraga

## Summary Adds a steam turbine governor and a three-stage steam turbine (HP/IP/LP) as separate objects, plus the Base::Governor and Base::Turbine interfaces. - New models: SteamTurbineGovernor (lead-lag + integrator with rate limiter) and SteamTurbine (HP/IP/LP stages) - addGovernorAndTurbine() on both SG base classes, same pattern as addExciter() (#402) and addPSS() (#486) - DQTrapez and VBR generators step the new chain when attached, fall back to TurbineGovernorType1 otherwise - Python bindings for set_parameters(), initialize_states(), and add_governor_and_turbine() - Docs with block diagrams and equations for both models ## What comes next Next PR adds the hydro variants using the same base classes. ## Other comments Continuation of the controllers work from @martinmoraga at ACS.

leonardocarreras force-pushed the feature-exciter branch from dfc7db0 to 120e12b Compare August 29, 2025 18:10

leonardocarreras force-pushed the feature-exciter branch 2 times, most recently from d27609a to 23eb53c Compare September 25, 2025 20:25

georgii-tishenin mentioned this pull request Oct 14, 2025

Generalized linear two terminal State Space Nodal component models #406

Merged

leonardocarreras force-pushed the feature-exciter branch from 660652b to 6e4af2e Compare December 14, 2025 14:58

leonardocarreras self-assigned this Dec 17, 2025

leonardocarreras added the enhancement New feature or request label Dec 17, 2025

leonardocarreras added this to DPsim Dec 17, 2025

pipeacosta force-pushed the feature-exciter branch 3 times, most recently from bf6b928 to 0759367 Compare May 19, 2026 16:10

leonardocarreras force-pushed the feature-exciter branch 2 times, most recently from 4242876 to 200ad58 Compare June 4, 2026 22:16

leonardocarreras marked this pull request as ready for review June 4, 2026 23:46

leonardocarreras requested review from dinkelbachjan, gnakti, m-mirz and stv0g as code owners June 4, 2026 23:46

leonardocarreras requested review from georgii-tishenin and pipeacosta June 4, 2026 23:47

georgii-tishenin reviewed Jun 5, 2026

View reviewed changes

leonardocarreras added 7 commits June 8, 2026 13:41

Add new base class and exciter models, remove old version

08b9baf

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Integrate the exciter models in the generator models

b34ae2f

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Adapt logger to new exciter

56f8d99

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Adapt examples to new exciter

c54f742

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add static case to factory

11c398f

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add python bindings

119e426

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Fix logging during param error

2836464

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

leonardocarreras added 10 commits June 8, 2026 13:41

Add default destructor to base class Exciter

9d63939

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Fix openmp guard flag not accounted in examples

45f95a6

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Make the tests more verbose again

9ffe7a8

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add attributes expected by examples and tests to exciter DC1 Simplified

a635445

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

use saturation in the example files

8add455

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add exciter documentation

6023b27

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add null check to single-arg addExciter overload

d3d2ddd

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add zero-divisor parameter validation in exciter setParameters

02bdd89

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Fix ExciterStatic parameter validation and step computation

cece73d

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Fix typos and sign error in exciter documentation

cbf8240

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

leonardocarreras force-pushed the feature-exciter branch from 50950c3 to cbf8240 Compare June 8, 2026 12:03

leonardocarreras marked this pull request as draft June 8, 2026 12:11

leonardocarreras added 2 commits June 8, 2026 14:17

Fix InvalidArgumentException call syntax in exciter setParameters

7616b86

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

Add example notebook

4a5f757

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>

leonardocarreras marked this pull request as ready for review June 8, 2026 13:04

leonardocarreras requested a review from georgii-tishenin June 8, 2026 13:48

georgii-tishenin approved these changes Jun 8, 2026

View reviewed changes

leonardocarreras merged commit 70ae13b into sogno-platform:master Jun 8, 2026
29 of 31 checks passed

github-project-automation Bot moved this to Done in DPsim Jun 8, 2026

leonardocarreras deleted the feature-exciter branch June 8, 2026 14:25

leonardocarreras mentioned this pull request Jun 9, 2026

feat: integrate TurbineGovernorType1 with SynchronGenerator and add Python bindings #490

Merged

This was referenced Jun 11, 2026

Feature: steam turbine governor + base governor and turbine #491

Merged

Feature: hydro turbine governor #492

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature: New exciter models#402

Feature: New exciter models#402
leonardocarreras merged 19 commits into
sogno-platform:masterfrom
leonardocarreras:feature-exciter

leonardocarreras commented Aug 29, 2025 •

edited

Loading

Uh oh!

leonardocarreras commented Jun 4, 2026

Uh oh!

codecov Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

georgii-tishenin left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

georgii-tishenin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

leonardocarreras commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leonardocarreras commented Jun 4, 2026

Uh oh!

codecov Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

georgii-tishenin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

georgii-tishenin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leonardocarreras commented Aug 29, 2025 •

edited

Loading

codecov Bot commented Jun 5, 2026 •

edited

Loading