Decoupling ITM#423
Merged
leonardocarreras merged 52 commits intoJun 29, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 67.40% 67.64% +0.23%
==========================================
Files 426 443 +17
Lines 25995 26917 +922
Branches 13217 13672 +455
==========================================
+ Hits 17523 18209 +686
- Misses 8471 8621 +150
- Partials 1 87 +86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pipeacosta
force-pushed
the
decoupling-itm
branch
2 times, most recently
from
November 24, 2025 12:39
37bcc73 to
3df984d
Compare
pipeacosta
marked this pull request as ready for review
November 25, 2025 11:57
pipeacosta
requested review from
dinkelbachjan,
gnakti,
m-mirz and
stv0g
as code owners
November 25, 2025 11:57
leonardocarreras
approved these changes
Nov 26, 2025
leonardocarreras
left a comment
Contributor
There was a problem hiding this comment.
Hi Andres! Thanks for the PR! This is just a quick first comment. We can discuss more and see how to integrate it.
leonardocarreras
requested changes
Nov 26, 2025
leonardocarreras
left a comment
Contributor
There was a problem hiding this comment.
Hi Andres! Please have a look to the comments! Thanks for the PR!
pipeacosta
force-pushed
the
decoupling-itm
branch
3 times, most recently
from
June 26, 2026 07:44
cd5e8de to
d0cb95d
Compare
leonardocarreras
requested changes
Jun 26, 2026
leonardocarreras
left a comment
Contributor
There was a problem hiding this comment.
Hi Andres! Thanks for updating your PR!
Here some suggestions/questions:
- The ITM variants have internal virtual nodes and 4 sub-components (mRes1, mRes2, mVoltageSrc, mCurrentSrc), which is exactly what
CompositePowerCompis designed for. Using CompositePowerComp would also fix the missing virtual node registration bug. This could also be a future refactor. - Please do not use the copyright block and instead use the SPDX headers.
/* SPDX-FileCopyrightText: 2026 Institute for Automation of Complex Power Systems, EONERC, RWTH Aachen University
* SPDX-License-Identifier: MPL-2.0
*/- Breaking changes need to be explicitly mentioned (Python API case of
SystemTopology.add)
Please feel free to propose a different way.
pipeacosta
force-pushed
the
decoupling-itm
branch
2 times, most recently
from
June 27, 2026 13:21
d73ae11 to
e1c4339
Compare
pipeacosta
force-pushed
the
decoupling-itm
branch
3 times, most recently
from
June 29, 2026 11:39
b3cce97 to
2a41493
Compare
leonardocarreras
self-requested a review
June 29, 2026 13:13
…ndTerminals. Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
- Initialize interface signals as MatrixComp instead of Matrix in DP_Ph1_ControlledVoltageSource - Set correct size of extrapolation ring buffers in DecouplingIdealTransformer_DP_Ph1 initialization Signed-off-by: pipeacosta <pipeacosta@gmail.com>
…e method. Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
…ed power. Signed-off-by: pipeacosta <pipeacosta@gmail.com>
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
pipeacosta
force-pushed
the
decoupling-itm
branch
from
June 29, 2026 14:09
2a41493 to
154dd85
Compare
leonardocarreras
self-requested a review
June 29, 2026 14:56
leonardocarreras
approved these changes
Jun 29, 2026
leonardocarreras
merged commit Jun 29, 2026
11238c0
into
sogno-platform:master
30 of 31 checks passed
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements new decoupling elements based on the Ideal Transformer Model (ITM) for exemplifying co-simulation scenarios.
This PR renames the Python API (dpsimpy) function
addtoadd_component.