General refactoring for increased modularity and separation of concerns#605
Open
alexpBCR wants to merge 1 commit intosokrypton:mainfrom
Open
General refactoring for increased modularity and separation of concerns#605alexpBCR wants to merge 1 commit intosokrypton:mainfrom
alexpBCR wants to merge 1 commit intosokrypton:mainfrom
Conversation
- Additional logging to allow better debuggability - Log calling parameters on colabfold's scripts internal functions - Create batches of msas before calling structure prediction on very high number sequence runs - Make changes to support one .m8 template file per sequence on the structure prediction step (colabfold batch) - General refactoring by separating functionality into functions thus increasing modularity and separation of concerns
alexpBCR
force-pushed
the
colabfold-refactoring
branch
from
9453519 to
68072a6
Compare
Collaborator
|
First of all, thanks a lot! I just want to give the heads up that this might take a bit to review as the PR is rather big (and us being permanently busy doesn't help either). |
Author
|
No problem! Let me know if you need any clarifications |
Collaborator
|
@milot-mirdita should we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Features:
Although this seems like a very large change, functionality as well as usage of the tool from the user's perspective is still exactly the same.
All tests passing.