Cap transaction history count and update Google auth dependency#27
Open
afurm wants to merge 1 commit intosolana-developers:mainfrom
Open
Cap transaction history count and update Google auth dependency#27afurm wants to merge 1 commit intosolana-developers:mainfrom
afurm wants to merge 1 commit intosolana-developers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/transactions/last?count=at 100 results.countvalues.countmaximum indocs/API.md.google-auth-libraryto10.6.2and refreshpackage-lock.json.Why
/transactions/lastaccepted any positive integer forcount, so an authorized caller could request an unbounded number of transaction rows. Capping the value keeps the endpoint predictable and limits unnecessary database and response work.The dependency update removes the production
gaxios -> uuidadvisory reported bynpm audit --omit=dev.Validation
npm testnpm audit --omit=devNote:
npm run test:e2ecould not run locally because Testcontainers could not find a working container runtime in this environment.