Stop logging faucet request secrets#56
Merged
Woody4618 merged 1 commit intosolana-developers:mainfrom Apr 30, 2026
Merged
Conversation
|
@afurm is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
That makes sense, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/request.Why
The faucet request handler previously logged the full
headers()object and the rawAuthorizationbearer token used for bypass checks. In production, that could expose session cookies, authorization headers, or privileged bypass tokens through application logs.Validation
npm run lintnpm run buildBoth passed. The repo still reports an existing React hook dependency warning in
components/AirdropForm.tsx, unrelated to this change.