Filter retired faucet keys from /monitor dashboard

[askov]

Summary

• The backend's /solana-balances/recent returns the last 30 days of samples with no account filter, so retired faucet addresses keep being plotted on /monitor for ~30 days after a key rotation. After Switch to new faucet key #53 switched the writer to dev2JBjy…, the previous web key (devwuNs…) is still showing on the chart because old rows are still in the recent window.
• Extract FAUCET_ACCOUNTS into lib/constants.ts and import it from both the writer (/api/monitorfaucet) and the reader (/monitor). The page filters incoming rows against this list, so retired keys are dropped at render time and the next key rotation becomes visually atomic.
• Extract the row → chartData transform from the page into a pure function (lib/monitor.ts) and add vitest with a fixture-based test that asserts the retired key is filtered.

Test plan

• npm test passes (6 tests in lib/__tests__/monitor.test.ts).
• npx tsc --noEmit passes.
• npm run lint shows no new warnings.
• npm run dev → http://localhost:3000/monitor: three charts render, devwuNs… does not appear in any series, DevTools console ALL KEYS: shows exactly the three current accounts in FAUCET_ACCOUNTS order.
• Temporarily reverting app/monitor/page.tsx reproduces the old behavior (retired key visible) — confirms the filter is doing real work.

[vercel]

@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[Copilot]

Pull request overview

This PR makes the /monitor dashboard ignore “retired” faucet accounts by centralizing the active faucet account list and filtering chart series at render time, and adds a small unit-test suite around the chart-data transform.

Changes:

• Introduces FAUCET_ACCOUNTS in lib/constants.ts and reuses it in both the balance writer (/api/monitorfaucet) and the monitor UI (/monitor).
• Extracts the rows → recharts data-shape transform into lib/monitor.ts (buildChartData) and applies filtering there.
• Adds Vitest config + fixture-based tests validating that retired keys are filtered out.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vitest.config.ts	Adds Vitest configuration for running library tests.
package.json	Adds test/test:watch scripts and Vitest dev dependency.
package-lock.json	Updates lockfile for Vitest and related dependency graph changes.
lib/monitor.ts	New pure transform to build chart series data while filtering to active faucet accounts.
lib/constants.ts	Defines canonical FAUCET_ACCOUNTS list used by writer and reader.
lib/__tests__/monitor.test.ts	Adds fixture-based unit tests covering filtering + grouping behavior.
lib/__tests__/fixtures/balances.json	Adds fixture dataset containing both active and retired accounts.
app/monitor/page.tsx	Uses FAUCET_ACCOUNTS and buildChartData instead of in-component transform logic.
app/api/monitorfaucet/route.ts	Reuses FAUCET_ACCOUNTS for the monitored account list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Balance.balance is typed as a number, but the added fixture (and common JSON/DB numeric serialization) provides balances as strings. This makes the type inaccurate and can leak string values into ChartData. Consider typing balance as number | string (or unknown) and normalizing to a number inside buildChartData before storing it.

[askov]

This inconsistency is not introduced by this PR, I think we could skip

[Copilot]

This fixture is a single very long line, which makes it hard to review diffs and update by hand. Consider pretty-printing it (multi-line, stable key ordering) so future changes are readable and merge-friendly.

[askov]

On purpose, I would keep as is. Nobody should review the file itself, only swap

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
solana-devnet-faucet	Error		May 11, 2026 2:28pm

[rogaldh]

I tried npm ci, and it failed. Worth fixing

[rogaldh]

Except this, LGTM