add hello solana asm example#538
Merged
Perelyn-sama merged 5 commits intoApr 13, 2026
Merged
Conversation
dev-jodee
self-requested a review
March 24, 2026 12:44
dev-jodee
requested changes
Mar 24, 2026
dev-jodee
left a comment
dev-jodee
left a comment
Collaborator
There was a problem hiding this comment.
Couple of small things to change :) thx for the work
dev-jodee
reviewed
Mar 27, 2026
dev-jodee
left a comment
dev-jodee
left a comment
Collaborator
There was a problem hiding this comment.
re on the solana dependency added -> Yes, but that dependency isn't used anywhere in your code itself
Contributor
Author
fair, removed. Also, thanks for the reviews. feels good to be making progress :) |
Collaborator
|
@Perelyn-sama of course ! and can you fix the conflict? after that I think we'll be good to merge |
dev-jodee
self-requested a review
April 13, 2026 14:43
dev-jodee
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.