docs(counter): fix native readme for the bankrun/pnpm flow#608
Merged
Conversation
The README still documented the removed yarn + solana-test-validator setup (yarn start-validator / yarn run-tests). counter/native now builds with cargo build-sbf and tests in-process via solana-bankrun, so document the current pnpm build-and-test / build / deploy scripts instead.
amilz
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basics/counter/native/README.mdstill documented the old, removed workflow (yarn test,yarn start-validator,yarn run-tests+ a localsolana-test-validator). Those scripts no longer exist.cargo build-sbfand tests in-process via solana-bankrun (no validator). Update the README to the currentpnpm build-and-test/pnpm build/pnpm deployscripts.Test Plan
basics/counter/native/package.jsonscripts, and thatcounter/nativebuilds + tests green in CI (bankrun, loads from./tests/fixtures).The underlying bug in the issue (the
./target/deploy/counter_solana_native.sonot-found error from the old yarn/validator setup) was already resolved by the rewrite to solana-bankrun; this finishes it by fixing the stale docs.Closes #67