program: test replenish for sub-minimum delegation#649
Open
2501babe wants to merge 1 commit intosolana-program:mainfrom
Open
program: test replenish for sub-minimum delegation#6492501babe wants to merge 1 commit intosolana-program:mainfrom
2501babe wants to merge 1 commit intosolana-program:mainfrom
Conversation
* test moving less than the minimum to onramp adds to activating but does not attempt to delegate inactive * test the no-op cases successfully no-op * use unique value for existing lamports in onramp
2dd09dd to
3d2bb28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while looking at onchain svsp transactions i noticed people will not uncommonly replenish in the thousands of lamports and realized we dont have tests that these instructions will still succeed after the minimum delegation goes to 1sol. the logic is clever... too clever to let it go untested:
also i cover the no-op cases that i previously skipped