Skip to content

Require pim:storage predicate if WebID is in agent's storage #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeswr wants to merge 1 commit into from
Closed

Require pim:storage predicate if WebID is in agent's storage #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ <h3 content="Solid WebID Profile Data Model" property="schema:name">Solid WebID
<li>One <code>rdf:type</code> property whose object is <code>foaf:Agent</code>.</li>
<li>One <code>pim:preferencesFile</code>.</li>
<li>Zero or one <code>ldp:inbox</code>.</li>
<li>Zero or more <code>pim:storage</code> properties to indicate agent's storages.</li>
<li>Zero or more <code>pim:storage</code> properties to indicate agent's storages. If the WebID in an agent's storage, that storage MUST be advertised.</li>

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new requirement sentence is ungrammatical (missing “is”) and currently ambiguous about what it means for a WebID to be “in an agent's storage” (WebID URI vs WebID profile document location). Please rephrase to clearly define the condition (e.g., when the WebID Profile Document is contained within a Solid Storage) and what exact storage URL must be advertised via pim:storage.

Suggested change
<li>Zero or more <code>pim:storage</code> properties to indicate agent's storages. If the WebID in an agent's storage, that storage MUST be advertised.</li>
<li>Zero or more <code>pim:storage</code> properties to indicate the agent's Solid storages. If the Solid WebID Profile Document is contained within a Solid Storage, the URL of that storage (for example, the root container URL of the storage) MUST be advertised via <code>pim:storage</code>.</li>

Copilot uses AI. Check for mistakes.

@jeff-zucker jeff-zucker Mar 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if the profile is located in a non-Solid server it's okay to not have a storage predicate? I think, the same conditions apply. Also I would change it to "If the WebID owner wishes to advertise their storage, they MUST ...". Because having a WebID without a public storage is a valid use case.

<li>Zero or more <code>rdfs:seeAlso</code> to refer to related <a href="#extended-profile-documents">documents
extending the profile.</a></li>
</ul>
Expand Down
Loading