chore: migrate eslint to flat config

Author: mrkvon

.eslintignore

@@ -0,0 +1,30 @@
+import eslint from '@eslint/js'
+import tsParser from '@typescript-eslint/parser'
+import eslintConfigPrettier from 'eslint-config-prettier/flat'
+import { defineConfig } from 'eslint/config'
+import globals from 'globals'
+import tseslint from 'typescript-eslint'
+
+export default defineConfig(
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  eslintConfigPrettier,
+  { ignores: ['dist', 'apidocs', 'vitest.config.ts'] },
+  {
+    languageOptions: {
+      globals: { ...globals.node },
+      parser: tsParser,
+      ecmaVersion: 9,
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        { args: 'after-used', ignoreRestSiblings: false },
+      ],
+      'no-console': 'warn',
+    },
+  },
+)

.eslintrc.yml

@@ -1,6 +1,6 @@
 {
   "project": ["**/*.{js,ts}"],
-  "entry": ["src/index.ts", "src/generate-api-docs.ts"],
+  "entry": ["src/generate-api-docs.ts"],
   "ignore": ["apidocs/*"],
   "ignoreDependencies": ["@types/co-body"],
   "ignoreBinaries": ["openssl"]

eslint.config.mjs

@@ -16,23 +16,23 @@
   },
   "license": "MIT",
   "devDependencies": {
+    "@eslint/js": "^9.39.2",
     "@solid/community-server": "^7.0.2",
     "@types/maildev": "^0.0.7",
-    "@typescript-eslint/eslint-plugin": "^8.54.0",
     "@typescript-eslint/parser": "^8.54.0",
     "cheerio": "^1.0.0-rc.12",
     "cross-fetch": "^4.0.0",
     "eslint": "^9.39.2",
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.4",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-prettier": "^5.0.0",
+    "globals": "^17.2.0",
     "knip": "^5.43.6",
     "maildev": "^2.1.0",
     "msw": "^2.0.14",
     "prettier": "^3.0.0",
     "puppeteer": "^24.33.0",
     "swagger-autogen": "^2.23.6",
+    "typescript-eslint": "^8.54.0",
     "vitest": "^4.0.16"
   },
   "dependencies": {

knip.json

@@ -7,7 +7,6 @@ import { sendMail } from '../services/mailerService.js'
 import { generateHtmlMessage } from '../templates/generateMessage.js'
 import { findWritableSettings, getBotFetch } from '../utils.js'
 
-// eslint-disable-next-line import/no-named-as-default-member
 const { JsonWebTokenError, TokenExpiredError, sign, verify } = jsonwebtoken
 
 export const initializeIntegration: Middleware<{

package.json

@@ -12,7 +12,6 @@ export const getVerifiedEmails = async (webId: string) => {
   const verifiedEmails = tokens
     .map(token => {
       try {
-        // eslint-disable-next-line import/no-named-as-default-member
         return jsonwebtoken.verify(token, pem) as {
           webId: string
           email: string

src/controllers/integration.ts

@@ -41,15 +41,15 @@ export const initIntegration = async ({
   expect(emailMessage).toBeDefined()
   const $ = cheerio.load(emailMessage as string)
   const verificationLink = $('a').first().attr('href')
-  expect(verificationLink).to.not.be.null
+  expect(verificationLink).to.not.equal(null)
   vi.restoreAllMocks()
 
   return { verificationLink }
 }
 
 const finishIntegration = async (verificationLink: string) => {
   const response = await fetch(verificationLink)
-  expect(response.ok).to.be.true
+  expect(response.ok).to.equal(true)
   const jwt = await response.text()
   return { token: jwt }
 }

src/controllers/status.ts

@@ -20,7 +20,7 @@ const createFile = async ({
     headers: { 'content-type': 'text/turtle' },
   })
 
-  expect(response.ok).to.be.true
+  expect(response.ok).to.equal(true)
 
   if (acl) {
     await addAcl({
@@ -81,7 +81,7 @@ const patchFile = async ({
     body: patch,
     headers: { 'content-type': 'text/n3' },
   })
-  expect(response.ok).to.be.true
+  expect(response.ok).to.equal(true)
 }
 
 /**
@@ -200,7 +200,7 @@ const addAcl = async ({
       }.`,
   })
 
-  expect(response.ok).to.be.true
+  expect(response.ok).to.equal(true)
 
   return response
 }

src/test/helpers/index.ts

@@ -48,7 +48,7 @@ describe('email verification via /verify-email?token=jwt', () => {
     const response = await fetch(verificationLink, {
       headers: { accept: 'text/plain' },
     })
-    expect(response.ok).to.be.true
+    expect(response.ok).to.equal(true)
     const jwt = await response.text()
     const payload = jsonwebtoken.decode(jwt) as jsonwebtoken.JwtPayload
 
@@ -68,7 +68,7 @@ describe('email verification via /verify-email?token=jwt', () => {
     const response = await fetch(verificationLink, {
       headers: { accept: 'application/json' },
     })
-    expect(response.ok).to.be.true
+    expect(response.ok).to.equal(true)
     const { token: jwt } = await response.json()
 
     // after, the settings should contain triple <webId> <verification token predicate (config)> "token".
@@ -85,7 +85,7 @@ describe('email verification via /verify-email?token=jwt', () => {
     const response = await fetch(verificationLink, {
       headers: { accept: 'text/html' },
     })
-    expect(response.ok).to.be.true
+    expect(response.ok).to.equal(true)
     const body = await response.text()
     expect(response.headers.get('content-type')).to.equal('text/html')
     expect(body).to.include('Your email was successfully verified')