feat: Auto-populate page field when reporting an issue#1051
feat: Auto-populate page field when reporting an issue#1051LadyBluenotes merged 43 commits intosolidjs:mainfrom
Conversation
Also makes the GitHub URL multiline for readabillity. Closes solidjs#1049
|
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
|
Quick note that this might be failing because it depends on/expects #1050 to be merged first. Maybe there was a more elegant way of doing this... 😆 Just let me know if I should rebase or anything like that! |
src/ui/page-issue-link.tsx
Outdated
| return `https://github.com/solidjs/solid-docs-next/issues/new` + | ||
| `?assignees=ladybluenotes` + | ||
| `&labels=improve+documentation%2Cpending+review` + | ||
| `&projects=` + | ||
| `&template=CONTENT.yml` + | ||
| `&title=[Content]:` + | ||
| `&subject=${getEntryFileName()}` + | ||
| `&page=${window.location.href}` | ||
| }); |
There was a problem hiding this comment.
@bertday A formatting issue is blocking this PR. Could you please format the file or use the following code:
return (
"https://github.com/solidjs/solid-docs-next/issues/new" +
"?assignees=ladybluenotes" +
"&labels=improve+documentation%2Cpending+review" +
"&projects=" +
"&template=CONTENT.yml" +
"&title=[Content]:" +
"&subject=${getEntryFileName()}" +
"&page=${window.location.href}"
);There was a problem hiding this comment.
Hi @amirhhashemi , this should be resolved now!
There was a problem hiding this comment.
@bertday My bad, I should've used ` instead of " for strings. I didn't notice template strings are required.
There was a problem hiding this comment.
Hi @amirhhashemi , just pushed a change to bring this backticks back. Really hoping this does this trick.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Amir Hossein Hashemi <87268103+amirhhashemi@users.noreply.github.com>
3 participants
Description(required)
This PR auto-populates the
pagefield of the GitHub issue template with the current window URL when the user clicks the "Report an issue with this page" link.Related issues & labels