Skip to content

Use SolidBase#1092

Merged
LadyBluenotes merged 43 commits intosolidjs:mainfrom
Brendonovich:solidbase
Mar 4, 2025
Merged

Use SolidBase#1092
LadyBluenotes merged 43 commits intosolidjs:mainfrom
Brendonovich:solidbase

Conversation

@Brendonovich
Copy link
Copy Markdown
Contributor

@Brendonovich Brendonovich commented Feb 23, 2025 •
edited
Loading

Replaces a few things with SolidBase:

  • MDX processing
  • Theme control
  • <Callout> component -> ::: directives
  • Table of contents

Is using @brendonovich/kobalte__solidbase for now until a new @kobalte/solidbase is published now using 0.0.9

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Feb 23, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 23, 2025 •
edited
Loading

✅ Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 9e7ffc0
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67c751aac4120600087b81a7
😎 Deploy Preview https://deploy-preview-1092--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

atilafassina
atilafassina approved these changes Feb 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Just dropped a small question about the i18n.

But clicked around and things look good, code looks great as well.
We should wait for @LadyBluenotes to have a look as well

Comment thread src/entry-server.tsx
LadyBluenotes
LadyBluenotes reviewed Feb 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@LadyBluenotes LadyBluenotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you so much for you and the team's work on getting this done.

While not a big problem, I did notice lighthouse is giving us a poorer SEO rating now. I'm not sure whether that should be addressed prior to merge (@atilafassina).

@Brendonovich
Copy link
Copy Markdown
Contributor Author

Brendonovich commented Feb 24, 2025

@LadyBluenotes I think the only difference is that the preview deployment blocks search engine indexing, which seems to have an outsized effect on SEO.

image

@jer3m01 jer3m01 mentioned this pull request Mar 3, 2025
Closed
@amirhhashemi amirhhashemi mentioned this pull request Mar 3, 2025
Merged
2 tasks
@LadyBluenotes LadyBluenotes merged commit 25fb030 into solidjs:main Mar 4, 2025
2 of 4 checks passed
@LadyBluenotes LadyBluenotes mentioned this pull request Mar 5, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LadyBluenotes LadyBluenotes LadyBluenotes approved these changes

@atilafassina atilafassina Awaiting requested review from atilafassina

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Brendonovich @atilafassina @LadyBluenotes @jer3m01