Add dedicated docs for innerHTML and textContent#1105
Merged
LadyBluenotes merged 14 commits intosolidjs:mainfrom Mar 8, 2025
Merged
Add dedicated docs for innerHTML and textContent#1105LadyBluenotes merged 14 commits intosolidjs:mainfrom
LadyBluenotes merged 14 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
jer3m01
reviewed
Mar 3, 2025
LadyBluenotes
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
innerHTMLandtextContentare documented on the same page, which may lead to some issues:innerHTMLhas certain security implications that should be considered.innerHTML, as it is more widely used. Including information abouttextContentcan create unnecessary friction.innerTextis not documented either. Should we also add its docs to the same page?Furthermore, there were a few issues with the content itself:
This PR addresses these issues. Additionally, I updated the the legacy routes redirector middleware to redirect to the
innerHTMLpage. This further highlights the problem of documenting multiple concepts on one page, as it limits our control over the URLs.