Improve writing of store setters with range and multiple indices#1110
Merged
LadyBluenotes merged 2 commits intomainfrom Mar 7, 2025
Merged
Improve writing of store setters with range and multiple indices#1110LadyBluenotes merged 2 commits intomainfrom
LadyBluenotes merged 2 commits intomainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LadyBluenotes
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stores have some magic syntax for modifying multiple elements at once: arrays and
{from, to, [step]}objects. Previously we called both of them "ranges", but only the latter is ranges. Now the category is "modifying multiple elements", and only one is called a range. I also noticed that the array syntax works for object properties too, so I documented that. Also added a bunch of examples, and added explicit equivalent code to explain exactly what they're doing. Also mentioned the key difference, which is batching.I didn't actually know these features, but did some basic testing to understand how they work. (The answer is: very generally.)
Related issues & labels
This PR was motivated by zulu's Discord message: