Migrate to SolidBase tabs and package helper#1135
Merged
LadyBluenotes merged 11 commits intosolidjs:mainfrom Mar 27, 2025
Merged
Migrate to SolidBase tabs and package helper#1135LadyBluenotes merged 11 commits intosolidjs:mainfrom
LadyBluenotes merged 11 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amirhhashemi
changed the title
jer3m01
requested changes
Mar 19, 2025
Member
jer3m01
left a comment
jer3m01
left a comment
There was a problem hiding this comment.
The exec, global install and create are a nice idea, I'll probably port it back to SolidBase.
There's a small temporary change to make below.
jer3m01
approved these changes
Mar 27, 2025
Member
jer3m01
left a comment
jer3m01
left a comment
There was a problem hiding this comment.
Looks good!
Maybe a small styling change to make the tabs scroll on small screens?
Collaborator
Author
|
@jer3m01 It should be fixed now |
LadyBluenotes
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
This PR:
package-syntax.Related issues & labels
PackageManagercomponent #1018, [Other]: Update example inTabsCodeBlockscomponent #1004