Update the structure of props and options reference#1136
Closed
amirhhashemi wants to merge 3 commits intosolidjs:mainfrom
Closed
Update the structure of props and options reference#1136amirhhashemi wants to merge 3 commits intosolidjs:mainfrom
amirhhashemi wants to merge 3 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
I'm not a fan of this change. I can understand why you may want to make it, but this was made without any prior conversation and it's structurally too large of a change to make without input. I'm going to close this while we talk about how we can approach this, but I'll reach out so we can have that discussion. Do you mind, for the time being, just putting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
This PR changes the structure of how we document props, parameters, and options. Instead of using a table format, we will now present the documentation as follows:
This new format allows for several benefits:
Related issues & labels
deferStream#987