Correct env type declaration filename in docs#1155
Merged
LadyBluenotes merged 1 commit intosolidjs:mainfrom Apr 7, 2025
Merged
Correct env type declaration filename in docs#1155LadyBluenotes merged 1 commit intosolidjs:mainfrom
LadyBluenotes merged 1 commit intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Maybe it would be good to also include the |
mau27galvez
changed the title
LadyBluenotes
approved these changes
Apr 7, 2025
Member
LadyBluenotes
left a comment
LadyBluenotes
left a comment
There was a problem hiding this comment.
Great catch! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The documentation incorrectly suggests using .env.d.ts for typing environment variables. However, based on both Vite's official docs and testing, type safety only works with env.d.ts or vite-env.d.ts—not .env.d.ts