Skip to content

Fix the background color of highlighted lines in dark mode#1168

Merged
LadyBluenotes merged 3 commits intosolidjs:mainfrom
amirhhashemi:fix-highlight-color-dark-mode
May 1, 2025
Merged

Fix the background color of highlighted lines in dark mode#1168
LadyBluenotes merged 3 commits intosolidjs:mainfrom
amirhhashemi:fix-highlight-color-dark-mode

Conversation

@amirhhashemi
Copy link
Copy Markdown
Collaborator

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR fixes the background color of highlighted lines in dark mode. The problems was the CSS selector for dark mode.

Before:
image

After:
2025-05-01_08-18

Related issues & labels

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link
Copy Markdown

netlify bot commented May 1, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 90ce85e
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6813a0ce3fd1540009e86a43
😎 Deploy Preview https://deploy-preview-1168--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) May 1, 2025 16:26
@LadyBluenotes LadyBluenotes merged commit cee6319 into solidjs:main May 1, 2025
3 checks passed
@amirhhashemi amirhhashemi deleted the fix-highlight-color-dark-mode branch May 2, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Content]:the content of the high-lighted code has very boor contrast and can pearly be seen

2 participants