Skip to content

Improve awkward styling and sentences in classList.mdx #1185

Merged
LadyBluenotes merged 11 commits intosolidjs:mainfrom
marvin-j97:patch-1
Jun 3, 2025
Merged

Improve awkward styling and sentences in classList.mdx #1185
LadyBluenotes merged 11 commits intosolidjs:mainfrom
marvin-j97:patch-1

Conversation

@marvin-j97
Copy link
Copy Markdown
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description

Improves styling in classList.mdx, by making backtick styling consistent for "class" and "classList".

Also fixes a sentence's paranthesis and its period.

improve styling and fix some sentences
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit b7db21a
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b91595c00200081299fc

1 similar comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit b7db21a
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b91595c00200081299fc

@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 74cb41e
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b9396ee5170008ea476f

@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 5bc7c08
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/683f280a13b8cc0008d98b0f
😎 Deploy Preview https://deploy-preview-1185--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes
Copy link
Copy Markdown
Member

Hi @marvin-j97 ! Thank you for putting this PR in.

Before I get to reviewing this, do you mind fixing it so the deploy preview works? The error I'm currently seeing on our Netlify logs is this:

git ref pull/1185/head does not exist or you do not have permission

@marvin-j97
Copy link
Copy Markdown
Contributor Author

Hi @marvin-j97 ! Thank you for putting this PR in.

Before I get to reviewing this, do you mind fixing it so the deploy preview works? The error I'm currently seeing on our Netlify logs is this:

git ref pull/1185/head does not exist or you do not have permission

Not sure what that means - that is a Netlify error... forks are always public anyway.

@LadyBluenotes
Copy link
Copy Markdown
Member

We need the deploy preview to work to make sure the build doesn't break. Could you either fix this PR, please, or re-submit the changes in a new PR one so it works?

@marvin-j97
Copy link
Copy Markdown
Contributor Author

marvin-j97 commented May 27, 2025

We need the deploy preview to work to make sure the build doesn't break. Could you either fix this PR, please, or re-submit the changes in a new PR one so it works?

There's nothing I did though that should prevent pulling the PR on Netlify's side... I just changed a markdown page.

Edit: I just noticed it built fine.

Comment thread src/routes/reference/jsx-attributes/classlist.mdx Outdated
Comment thread src/routes/reference/jsx-attributes/classlist.mdx Outdated
Comment thread src/routes/reference/jsx-attributes/classlist.mdx Outdated
@LadyBluenotes LadyBluenotes enabled auto-merge (squash) June 1, 2025 23:39
@LadyBluenotes LadyBluenotes disabled auto-merge June 1, 2025 23:40
Co-authored-by: Sarah <hello@sarahgerrard.me>
@marvin-j97
Copy link
Copy Markdown
Contributor Author

The page could probably use a warning banner if we 100% know classList will be removed in v2.

@LadyBluenotes
Copy link
Copy Markdown
Member

@marvin-j97 thanks for the contribution.

We will leave any depreciation warnings until things are confirmed.

@LadyBluenotes LadyBluenotes merged commit a15aad9 into solidjs:main Jun 3, 2025
7 checks passed
@marvin-j97 marvin-j97 deleted the patch-1 branch June 3, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants