Improve awkward styling and sentences in classList.mdx #1185
Improve awkward styling and sentences in classList.mdx #1185LadyBluenotes merged 11 commits intosolidjs:mainfrom
Conversation
improve styling and fix some sentences
|
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
1 similar comment
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @marvin-j97 ! Thank you for putting this PR in. Before I get to reviewing this, do you mind fixing it so the deploy preview works? The error I'm currently seeing on our Netlify logs is this: |
Not sure what that means - that is a Netlify error... forks are always public anyway. |
|
We need the deploy preview to work to make sure the build doesn't break. Could you either fix this PR, please, or re-submit the changes in a new PR one so it works? |
There's nothing I did though that should prevent pulling the PR on Netlify's side... I just changed a markdown page. Edit: I just noticed it built fine. |
Co-authored-by: Sarah <hello@sarahgerrard.me>
Co-authored-by: Sarah <hello@sarahgerrard.me>
Co-authored-by: Sarah <hello@sarahgerrard.me>
|
The page could probably use a warning banner if we 100% know |
|
@marvin-j97 thanks for the contribution. We will leave any depreciation warnings until things are confirmed. |
Description
Improves styling in classList.mdx, by making backtick styling consistent for "class" and "classList".
Also fixes a sentence's paranthesis and its period.