fix: replace obsolete vite env references with VITE_ENVIRONMENTS constant

Author: katywings

packages/start/src/config/fs-routes/index.ts

@@ -1,6 +1,7 @@
 import { relative } from "node:path";
-import type { PluginOption, ResolvedConfig } from "vite";
+import type { PluginOption } from "vite";
 
+import { VITE_ENVIRONMENTS } from "../../constants.js";
 import { fileSystemWatcher } from "./fs-watcher.js";
 import type { BaseFileSystemRouter } from "./router.js";
 import { treeShake } from "./tree-shake.js";
@@ -57,7 +58,7 @@ export function fsRoutes({ routers }: FsRoutesArgs): Array<PluginOption> {
               src: relative(root, buildId),
               build: isBuild ? `_$() => import(/* @vite-ignore */ '${buildId}')$_` : undefined,
               import:
-                this.environment.name === "server"
+                this.environment.name === VITE_ENVIRONMENTS.server
                   ? `_$() => import(/* @vite-ignore */ '${buildId}')$_`
                   : `_$(() => clientManifestImport('${relative(root, buildId)}'))$_`
             };
@@ -69,7 +70,7 @@ export function fsRoutes({ routers }: FsRoutesArgs): Array<PluginOption> {
 
         const code = `
 ${js.getImportStatements()}
-${this.environment.name === "server"
+${this.environment.name === VITE_ENVIRONMENTS.server
             ? ""
             : `
 import { getClientManifest } from "solid-start:get-client-manifest";

packages/start/src/config/index.ts

@@ -83,7 +83,7 @@ function solidStartVitePlugin(options?: SolidStartOptions): Array<PluginOption>
       configEnvironment(name) {
         return {
           define: {
-            "import.meta.env.SSR": JSON.stringify(name === "server")
+            "import.meta.env.SSR": JSON.stringify(name === VITE_ENVIRONMENTS.server)
           }
         };
       },

packages/start/src/config/nitroPlugin.ts

@@ -1,5 +1,3 @@
-import { promises as fsp } from "node:fs";
-import path, { dirname, resolve } from "node:path";
 import {
   createApp,
   createEvent,
@@ -16,6 +14,8 @@ import {
   prepare,
   prerender,
 } from "nitropack";
+import { promises as fsp } from "node:fs";
+import path, { dirname, resolve } from "node:path";
 import {
   type Connect,
   type EnvironmentOptions,
@@ -129,7 +129,7 @@ export function nitroPlugin(
     {
       name: "solid-start-vite-plugin-nitro",
       configEnvironment(name) {
-        if (name === "server") {
+        if (name === VITE_ENVIRONMENTS.server) {
           return {
             build: {
               commonjsOptions: {
@@ -151,8 +151,8 @@ export function nitroPlugin(
           builder: {
             sharedPlugins: true,
             async buildApp(builder) {
-              const clientEnv = builder.environments["client"];
-              const serverEnv = builder.environments["server"];
+              const clientEnv = builder.environments[VITE_ENVIRONMENTS.client];
+              const serverEnv = builder.environments[VITE_ENVIRONMENTS.server];
 
               if (!clientEnv) throw new Error("Client environment not found");
               if (!serverEnv) throw new Error("SSR environment not found");