cleanup

Author: Brendonovich

apps/tests/src/routes/http-header.tsx

@@ -1,10 +1,10 @@
-import { HttpHeader } from "../../../../packages/start/src/shared/HttpHeader";
+import { HttpHeader } from "@solidjs/start";
 
 export default function HttpHeaderRoute() {
     return (
         <main>
-            <h1> Http Header </h1>
+            <h1>Http Header</h1>
             <HttpHeader name="test-header" value="test-value" />
         </main>
     );
-}
+}

packages/start/src/index.ts

@@ -17,4 +17,3 @@ export { GET } from "./shared/GET.ts";
 export { HttpHeader } from "./shared/HttpHeader.tsx";
 export { HttpStatusCode } from "./shared/HttpStatusCode.ts";
 export { getServerFunctionMeta } from "./shared/serverFunction.ts";
-

packages/start/src/shared/HttpHeader.tsx

@@ -2,6 +2,7 @@
 import { onCleanup } from "solid-js";
 import { getRequestEvent, isServer } from "solid-js/web";
 import type { PageEvent } from "../server/types";
+import { appendHeader, setHeader } from "../http";
 
 export interface HttpHeaderProps {
   name: string;
@@ -17,8 +18,8 @@ export const HttpHeader = isServer
   ? (props: HttpHeaderProps) => {
     const event = getRequestEvent() as PageEvent;
 
-    if (props.append) event.response.headers.append(props.name, props.value);
-    else event.response.headers.set(props.name, props.value);
+    if (props.append) appendHeader(props.name, props.value);
+    else setHeader(props.name, props.value);
 
     onCleanup(() => {
       // @ts-expect-error