Skip to content

Commit 38ef1d0

Browse files
committed
feat: changes git test workflow
1 parent 03362a5 commit 38ef1d0

1 file changed

Lines changed: 12 additions & 29 deletions

File tree

.github/workflows/tests.yml

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@ name: 🧪 Tests
22

33
on:
44
workflow_dispatch:
5+
# Add remaining triggers
56
pull_request:
6-
branches: [main, 1.x]
7+
branches: [main]
78
push:
8-
branches: [main, 1.x]
9+
branches: [main]
910

1011
jobs:
1112
tests:
12-
name: "🧪 Tests"
13+
name: "🧪 Run All Tests"
1314
runs-on: ubuntu-24.04
1415
steps:
1516
- uses: actions/checkout@v3
@@ -25,37 +26,19 @@ jobs:
2526
- name: Install project dependencies
2627
run: pnpm i
2728

28-
- name: Install Cypress binary
29-
run: pnpm exec cypress install
29+
- name: Install Playwright Browsers
30+
run: pnpm exec playwright install chromium
3031

3132
- name: Build SolidStart
3233
run: pnpm --filter @solidjs/start build
3334

3435
- name: Build Test Project
3536
run: pnpm --filter tests build
3637

37-
- name: Run unit tests
38-
run: pnpm --filter tests unit:ci
38+
- name: Run all apps/tests (Unit, Node, Browser UI, and E2E)
39+
run: pnpm --filter tests run test:all
3940

40-
- name: Run start unit tests
41-
run: pnpm --filter @solidjs/start test:ci
42-
43-
- name: E2E Chromium
44-
uses: cypress-io/github-action@v6
45-
with:
46-
project: ./apps/tests
47-
install: false
48-
start: pnpm --filter tests start --host 127.0.0.1 --port 3000
49-
wait-on: "http://127.0.0.1:3000"
50-
wait-on-timeout: 120
51-
browser: chromium
52-
53-
- name: E2E Firefox
54-
uses: cypress-io/github-action@v6
55-
with:
56-
project: ./apps/tests
57-
install: false
58-
start: pnpm --filter tests start --host 127.0.0.1 --port 3000
59-
wait-on: "http://127.0.0.1:3000"
60-
wait-on-timeout: 120
61-
browser: firefox
41+
# The @solidjs/start package currently has no tests, so we are skipping this step.
42+
# Uncomment if tests are added to the @solidjs/start package.
43+
# - name: Run @solidjs/start unit tests
44+
# run: pnpm --filter @solidjs/start test:ci

0 commit comments

Comments
 (0)