handle absolute paths properly

Author: Brendonovich

packages/start/src/server/server-fns-runtime.ts

@@ -4,11 +4,13 @@ import { provideRequestEvent } from "solid-js/web/storage";
 export function createServerReference(fn: Function, id: string) {
   if (typeof fn !== "function")
     throw new Error("Export from a 'use server' module must be a function");
-  const baseURL = import.meta.env.BASE_URL ?? "";
+  let baseURL = import.meta.env.BASE_URL ?? "/";
+  if(!baseURL.endsWith("/")) baseURL += "/"
+
   return new Proxy(fn, {
     get(target, prop, receiver) {
       if (prop === "url") {
-        return `${baseURL}/_server?id=${encodeURIComponent(id)}`;
+        return `${baseURL}_server?id=${encodeURIComponent(id)}`;
       }
       if (prop === "GET") return receiver;
       return (target as any)[prop];

packages/start/src/server/server-runtime.ts

@@ -1,4 +1,5 @@
 // @ts-ignore - seroval exports issue with NodeNext
+import { join } from "pathe";
 import { deserialize, toJSONAsync } from "seroval";
 import {
   CustomEventPlugin,
@@ -193,19 +194,21 @@ async function fetchServerFunction(
 }
 
 export function createServerReference(id: string) {
-  const baseURL = import.meta.env.BASE_URL ?? "";
-  const fn = (...args: any[]) => fetchServerFunction(`${baseURL}/_server`, id, {}, args);
+  let baseURL = import.meta.env.BASE_URL ?? "/";
+  if(!baseURL.endsWith("/")) baseURL += "/"
+
+  const fn = (...args: any[]) => fetchServerFunction(`${baseURL}_server`, id, {}, args);
 
   return new Proxy(fn, {
     get(target, prop, receiver) {
       if (prop === "url") {
-        return `${baseURL}/_server?id=${encodeURIComponent(id)}`;
+        return `${baseURL}_server?id=${encodeURIComponent(id)}`;
       }
       if (prop === "GET") {
         return receiver.withOptions({ method: "GET" });
       }
       if (prop === "withOptions") {
-        const url = `${baseURL}/_server?id=${encodeURIComponent(id)}`;
+        const url = `${baseURL}_server?id=${encodeURIComponent(id)}`;
         return (options: RequestInit) => {
           const fn = async (...args: any[]) => {
             const encodeArgs = options.method && options.method.toUpperCase() === "GET";
@@ -217,7 +220,7 @@ export function createServerReference(id: string) {
                           JSON.stringify(await Promise.resolve(toJSONAsync(args, { plugins })))
                         )}`
                       : "")
-                : `${baseURL}/_server`,
+                : `${baseURL}_server`,
               id,
               options,
               encodeArgs ? [] : args