fix: dont server render url imported css

Author: katywings

packages/start/src/server/collect-styles.ts

@@ -164,12 +164,16 @@ export async function findStylesInModuleGraph(
 
 	const styles: Record<string, any> = {};
 
-	for (const dep of dependencies) {
-		if (isCssFile(dep.url)) {
-			let depURL = dep.url;
-			if (!isCssUrlWithoutSideEffects(depURL)) {
-				depURL = injectQuery(dep.url, "inline");
-			}
+  for (const dep of dependencies) {
+    if (isCssFile(dep.url)) {
+      let depURL = dep.url;
+      if (depURL.endsWith("?url")) {
+        continue;
+      }
+
+      if (!isCssUrlWithoutSideEffects(depURL)) {
+        depURL = injectQuery(dep.url, "inline");
+      }
 
       styles[join(vite.config.root, dep.url)] = dep.url;
 		}

packages/start/src/server/manifest/prod-ssr-manifest.ts

@@ -1,5 +1,6 @@
 import { clientViteManifest } from "solid-start:client-vite-manifest";
 import { join } from "pathe";
+import { Manifest } from "vite";
 import type { Asset } from "../renderAsset.tsx";
 
 // Only reads from client manifest atm, might need server support for islands
@@ -66,7 +67,7 @@ function createHtmlTagsForAssets(assets: string[]) {
 }
 
 function findAssetsInViteManifest(
-	manifest: any,
+	manifest: Manifest,
 	id: string,
 	assetMap = new Map(),
 	stack: string[] = [],
@@ -85,7 +86,8 @@ function findAssetsInViteManifest(
 	}
 
 	const assets = [
-		...(chunk.assets?.filter(Boolean) || []),
+		// TODO: Needs a better way to detect ?url
+		...(chunk.assets?.filter(a => !a.endsWith('.css')) || []),
 		...(chunk.css?.filter(Boolean) || []),
 	];
 	if (chunk.imports) {
@@ -94,7 +96,7 @@ function findAssetsInViteManifest(
 			assets.push(
 				...findAssetsInViteManifest(
 					manifest,
-					chunk.imports[i],
+					chunk.imports[i]!,
 					assetMap,
 					stack,
 				),