fix: exclude css with ? import sideeffects from ssr

Author: katywings

packages/start/src/server/collect-styles.ts

@@ -63,7 +63,7 @@ async function findModuleDependencies(
 // Vite doesn't expose these so we just copy the list for now
 // https://github.com/vitejs/vite/blob/d6bde8b03d433778aaed62afc2be0630c8131908/packages/vite/src/node/constants.ts#L49C23-L50
 const cssFileRegExp =
-	/\.(css|less|sass|scss|styl|stylus|pcss|postcss|sss)(?:$|\?)/;
+	/\.(css|less|sass|scss|styl|stylus|pcss|postcss|sss)$/;
 // https://github.com/vitejs/vite/blob/d6bde8b03d433778aaed62afc2be0630c8131908/packages/vite/src/node/plugins/css.ts#L160
 const cssModulesRegExp = new RegExp(`\\.module${cssFileRegExp.source}`);
 

packages/start/src/server/manifest/prod-ssr-manifest.ts

@@ -1,5 +1,6 @@
 import { clientViteManifest } from "solid-start:client-vite-manifest";
 import { join } from "pathe";
+import { Manifest } from "vite";
 import type { Asset } from "../renderAsset.tsx";
 
 // Only reads from client manifest atm, might need server support for islands
@@ -70,7 +71,7 @@ const entryId = import.meta.env.START_CLIENT_ENTRY.slice(2);
 let entryImports: string[] | undefined = undefined;
 
 function findAssetsInViteManifest(
-	manifest: any,
+	manifest: Manifest,
 	id: string,
 	assetMap = new Map(),
 	stack: string[] = [],
@@ -99,10 +100,7 @@ function findAssetsInViteManifest(
 	// Chunks (e.g. routes) that import something from entry, should not render entry css redundantly
 	const excludeEntryImports = id !== entryId;
 
-	const assets = [
-		...(chunk.assets?.filter(Boolean) || []),
-		...(chunk.css?.filter(Boolean) || []),
-	];
+	const assets = chunk.css?.filter(Boolean) || [];
 	if (chunk.imports) {
 		stack.push(id);
 		for (let i = 0, l = chunk.imports.length; i < l; i++) {