Skip to content

fix: vite config types#1856

Merged
atilafassina merged 1 commit intosolidjs:mainfrom
huseeiin:main
Aug 5, 2025
Merged

fix: vite config types#1856
atilafassina merged 1 commit intosolidjs:mainfrom
huseeiin:main

Conversation

@huseeiin
Copy link
Copy Markdown
Contributor

now you'll get better type hints

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 18, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 7f85264
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6891d374b9c9a400080c2587
😎 Deploy Preview https://deploy-preview-1856--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 18, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 7f85264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@huseeiin
Copy link
Copy Markdown
Contributor Author

this also adds extensions to output .d.ts files so that projects with moduleResolution: "nodenext" can consume @solidjs/start, this doesn't change solid's moduleResolution.

@birkskyum birkskyum changed the title fix vite config types fix: vite config types Mar 20, 2025
@birkskyum
Copy link
Copy Markdown
Member

birkskyum commented Mar 20, 2025

@atilafassina , is this Contrib CI check blocking because of the heseeiin:main is the main branch and not a feature branch? can we turn that piece of the check off?

@huseeiin
Copy link
Copy Markdown
Contributor Author

also added brotli compression in bun

@atilafassina atilafassina merged commit af520c5 into solidjs:main Aug 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants