Skip to content

fix: fetchEvent -> HeaderProxy checks for null instead of undefined #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atilafassina merged 2 commits into from
Aug 28, 2025
Merged

fix: fetchEvent -> HeaderProxy checks for null instead of undefined #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb4c3c
fix: check for `null` instad of `undefined`
huseeiin Jul 10, 2025
5d5c872
add changeset
huseeiin Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/open-ducks-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

fix: check for `null` instad of `undefined` in `HeaderProxy`
2 changes: 1 addition & 1 deletion packages/start/src/server/fetchEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class HeaderProxy {
return Array.isArray(h) ? h.join(", ") : (h as string) || null;
}
has(key: string) {
return this.get(key) !== undefined;
return this.get(key) !== null;
Comment thread
atilafassina marked this conversation as resolved.
}
set(key: string, value: string) {
return setResponseHeader(this.event, key, value);
Expand Down
Loading