Skip to content

fix: overhaul headers proxy#1937

Closed
huseeiin wants to merge 4 commits intosolidjs:mainfrom
huseeiin:headers-feature
Closed

fix: overhaul headers proxy#1937
huseeiin wants to merge 4 commits intosolidjs:mainfrom
huseeiin:headers-feature

Conversation

@huseeiin
Copy link
Copy Markdown
Contributor

@huseeiin huseeiin commented Aug 8, 2025

this fixes many issues with the original headers proxy, for example, now:
getRequestEvent().response.headers.toString() returns "[object Headers]" instead of "[object Object]"
getRequestEvent().response.headers instanceof Headers will return true
and so on, because we're now using a native Headers object

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 8, 2025

🦋 Changeset detected

Latest commit: c2bfa86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 8, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit c2bfa86
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6895ff06ed09f40008b31d05
😎 Deploy Preview https://deploy-preview-1937--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 8, 2025

@huseeiin
Copy link
Copy Markdown
Contributor Author

huseeiin commented Aug 9, 2025

don't merge this, its stupid. after h3 v2 we will get a proper response Headers

@huseeiin huseeiin closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant