Skip to content

More aggressive code extraction for top-level "use server" declarations#1943

Closed
atilafassina wants to merge 3 commits intomainfrom
agents
Closed

More aggressive code extraction for top-level "use server" declarations#1943
atilafassina wants to merge 3 commits intomainfrom
agents

Conversation

@atilafassina
Copy link
Copy Markdown
Member

  • add AGENTS.md
  • fix: global declarations in top-level "use server" could cause leaks

This addresses an issue that could cause secret leaks.
When defining adding a console.* declaration, to a top-level "use server" module, the log would end up in the client-bundle.

Testing

Build an app (/packages/test) and run

cd /packages/test && grep -rl 'SERVER ONLY SECRET' .

There should be no matches in **/client/** files.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 16, 2025

🦋 Changeset detected

Latest commit: 074845e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 16, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 074845e
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/68a059ed27901300080ceb03
😎 Deploy Preview https://deploy-preview-1943--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Aug 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant