From 618e2c8cdc3533e420ad4b484e2b164c28fc661f Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 10:58:42 +0200 Subject: [PATCH 1/6] Fix CONTRIBUTING.md --- CONTRIBUTING.md | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 535772321..707c775b1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,18 +5,18 @@ We welcome contributions including bug fixes, feature enhancements, documentatio ## Creating a Template -We do not maintain official templates and integration in this monorepo. +We do not maintain official templates and integrations in this monorepo. Instead, please head over to [solidjs/templates](https://github.com/solidjs/templates) to submit your contribution. ## Documentation We always want help and creative ways of explaining how to take the best out of SolidStart. -Alas, this is not the right place to do it, please head over to [SolidDocs](https://github.com/solidjs/solid-docs) and offer contribution to the official documentation! +Alas, this is not the right place to do it, please head over to [SolidDocs](https://github.com/solidjs/solid-docs) and contribute to the official documentation! ## Feature Request > [!IMPORTANT] -> Do not create a PR without first discussion in an issue +> Do not create a PR without prior discussion in an issue If there's a new feature you'd like to request you can: @@ -24,10 +24,10 @@ If there's a new feature you'd like to request you can: 2. If it's a more general concept, feel free to open a [Discussion](https://github.com/solidjs/solid-start/discussions) in the **Idea** category. -A new **primitive** follows the same criteria as issues, please create an issue for it to be discussed before hand. +A new **primitive** follows the same criteria as issues, please create an issue for it to be discussed beforehand. Primitives that depend on multiple external dependencies and 3rd party integrations are generally not a good fit to live inside this monorepo, we still welcome you to create it and share with the ecosystem. -Reach out in a [Discussion](https://github.com/solidjs/solid-start/discussions) in the **showcase** session and we'll amplify as much as we can! +Reach out in a [Discussion](https://github.com/solidjs/solid-start/discussions) in the **showcase** section and we'll amplify as much as we can! ## Found a Bug @@ -42,13 +42,13 @@ Create a **minimal** reproduction either in a remote IDE or in an open-source re We recommend using the `create-solid` package with the **basic** setting. -| Package Manager | Command | -| --------------- | ------------------------------------------ | -| pnpm | `pnpm create solid -s -t basic` | -| npm | `npm create solid -s -t basic` | -| yarn | `yarn create solid -s -t basic` | -| bun | `bun create solid -s -t basic` | -| deno | `deno run -A npm:create-solid -s -t basic` | +| Package Manager | Command | +| --------------- | ---------------------------------------- | +| pnpm | `pnpm create solid@latest -st basic` | +| npm | `npm create solid@latest -- -st basic` | +| yarn | `yarn create solid@latest -st basic` | +| bun | `bun create solid@latest --s --t basic` | +| deno | `deno run -A npm:create-solid -st basic` | ### Failing Test PR @@ -56,7 +56,7 @@ You can also fork this repository and go to `apps/tests`. There we have an app with all default configurations and many routes. Create a new route, a Cypress assertion to it and open a PR with the failing test-case. -Once the PR is there, **create an issue** and link the PR (mention the PR as you'd mention a person in the issue description and vice-versa). +Once the PR is there, **create an issue** and link the PR (mention the PR as you'd mention a person in the issue description and vice versa). > [!IMPORTANT] > Mark the **allow edit by the maintainers** so we can more easily investigate the failing test and propose a fix. Otherwise we may need to close your PR and cherry-pick your commit. From 3cea2ef73b1e7d3efac3cab42df8af0ada32983d Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 11:07:24 +0200 Subject: [PATCH 2/6] Fix README.md --- README.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 88d39535b..bbcae933d 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ -[![Banner](https://assets.solidjs.com/banner?project=Start&type=core)](https://github.com/solidjs) -
+[![Banner](https://assets.solidjs.com/banner?project=Start&type=core)](https://github.com/solidjs) + [![Version](https://img.shields.io/npm/v/@solidjs/start.svg?style=for-the-badge&color=blue&logo=npm)](https://npmjs.com/package/@solidjs/start) [![Downloads](https://img.shields.io/npm/dm/@solidjs/start.svg?style=for-the-badge&color=green&logo=npm)](https://npmjs.com/package/@solidjs/start) [![Stars](https://img.shields.io/github/stars/solidjs/solid-start?style=for-the-badge&color=yellow&logo=github)](https://github.com/solidjs/solid-start) @@ -11,18 +11,18 @@
- For contributing to codebase, check [CONTRIBUTING.md](/CONTRIBUTING.md) -- For creating a new template, please head on to [solidjs/templates](https://github.com/solidjs/templates) +- For creating a new template, please head over to [solidjs/templates](https://github.com/solidjs/templates) - For instructions on building with SolidStart, check the [package README.md](/packages/start/README.md) and our [official docs](https://docs.solidjs.com/solid-start) ## Prerequisites -- **Node.js**: Use the version specified in `.nvmrc`, to manage multiple versions across your system, we recommend a version manager such as [fnm](https://github.com/Schniz/fnm), or another of your preference. +- **Node.js**: Use the version specified in `.nvmrc`. To manage multiple versions across your system, we recommend a version manager such as [fnm](https://github.com/Schniz/fnm), or another of your preference. - **pnpm**: Install globally via `npm install -g pnpm`. Or let **Corepack** handle it in the setup step below. -- **Git**: Ensure Git is installed for cloning and managing the repository +- **Git**: Ensure Git is installed for cloning and managing the repository. ## Monorepo Structure -SolidStart is a pnpm-based monorepo with nested workspaces. Key directories include +SolidStart is a pnpm-based monorepo with nested workspaces. Key directories include: - **`packages/start`**: The core `@solidjs/start` package. - **`apps/landing-page`**: The official landing page. @@ -52,7 +52,7 @@ Use pnpm filters (e.g. `pnpm --filter @solidjs/start ...`) to target specific pa pnpm dedupe ``` - (`pnpm dedupe` will install dependencies _and_ clean the lockfile from duplicates, useful to preventing conflicts). + (`pnpm dedupe` will install dependencies _and_ clean the lockfile from duplicates, useful for preventing conflicts). 4. Build all packages and the landing page ```bash @@ -69,7 +69,7 @@ Then reinstall dependencies and rebuild. ## Running Tests -End-to-end tests are located in `apps/tests` projects. For manual testing and development there's the `apps/fixtures` apps, and finally, integration and unit tests live inside their respective packages. +End-to-end tests are located in `apps/tests` projects. For manual testing and development use the `apps/fixtures` apps, and finally, integration and unit tests live inside their respective packages. 1. Install the Cypress binary (required only once) From 2a3abd16511b586bbc6300172513bf0e9ae7e067 Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 11:12:50 +0200 Subject: [PATCH 3/6] Update --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bbcae933d..c3a62f665 100644 --- a/README.md +++ b/README.md @@ -10,9 +10,9 @@ +- For building apps with SolidStart, check the [package README](/packages/start/README.md) and our [official docs](https://docs.solidjs.com/solid-start) - For contributing to codebase, check [CONTRIBUTING.md](/CONTRIBUTING.md) - For creating a new template, please head over to [solidjs/templates](https://github.com/solidjs/templates) -- For instructions on building with SolidStart, check the [package README.md](/packages/start/README.md) and our [official docs](https://docs.solidjs.com/solid-start) ## Prerequisites From a98192978356c5070917c82452c39fcddb6e555f Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 11:16:54 +0200 Subject: [PATCH 4/6] Fix punctuation and wording in README.md --- packages/start/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/start/README.md b/packages/start/README.md index 295fc55bd..c0cf2e48c 100644 --- a/packages/start/README.md +++ b/packages/start/README.md @@ -73,7 +73,7 @@ export default defineConfig({ }); ``` -Presets also include runtimes like Node.js, Bun or Deno. For example, a preset like `node-server` enables hosting on your server. +Presets also include runtimes like Node.js, Bun, or Deno. For example, a preset like `node-server` enables hosting on your server. Learn more about [`defineConfig`](https://docs.solidjs.com/solid-start/reference/config/define-config) ## Building @@ -89,4 +89,4 @@ After the build completes, you’ll be guided through deployment for your specif ## Contributing - For contributing to the codebase, check [CONTRIBUTING.md](https://github.com/solidjs/solid-start/blob/main/CONTRIBUTING.md) -- For creating a new template, please head on to [solidjs/templates](https://github.com/solidjs/templates) +- For creating a new template, please head over to [solidjs/templates](https://github.com/solidjs/templates) From ceabd721e01c93373eb3d19653e297b1695b79a6 Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 11:18:12 +0200 Subject: [PATCH 5/6] Update wording in prerequisites section of README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c3a62f665..5f216310d 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ ## Prerequisites -- **Node.js**: Use the version specified in `.nvmrc`. To manage multiple versions across your system, we recommend a version manager such as [fnm](https://github.com/Schniz/fnm), or another of your preference. +- **Node.js**: Use the version specified in `.nvmrc`. To manage multiple versions across your system, we recommend a version manager such as [fnm](https://github.com/Schniz/fnm), or another of your choice. - **pnpm**: Install globally via `npm install -g pnpm`. Or let **Corepack** handle it in the setup step below. - **Git**: Ensure Git is installed for cloning and managing the repository. From 0c16e9a8091a243b13a2fdc8537300bfda71a811 Mon Sep 17 00:00:00 2001 From: Thomas Date: Sat, 4 Oct 2025 11:29:54 +0200 Subject: [PATCH 6/6] Update yarn command in CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 707c775b1..c1b857e05 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,7 +46,7 @@ We recommend using the `create-solid` package with the **basic** setting. | --------------- | ---------------------------------------- | | pnpm | `pnpm create solid@latest -st basic` | | npm | `npm create solid@latest -- -st basic` | -| yarn | `yarn create solid@latest -st basic` | +| yarn | `yarn create solid -st basic` | | bun | `bun create solid@latest --s --t basic` | | deno | `deno run -A npm:create-solid -st basic` |