Skip to content

fix: explicit type imports #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atilafassina merged 1 commit into from
Nov 19, 2025
+11 −11
Merged

fix: explicit type imports #2001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/start/src/config/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { PluginOption, ViteDevServer } from "vite";
import { type PluginOption, type ViteDevServer } from "vite";

import { findStylesInModuleGraph } from "../server/collect-styles.ts";
import { VIRTUAL_MODULES } from "./constants.ts";
import { SolidStartOptions } from "./index.ts";
import { type SolidStartOptions } from "./index.ts";

export function manifest(start: SolidStartOptions): PluginOption {
let devServer: ViteDevServer = undefined!;
return {
return {
name: "solid-start:manifest-plugin",
enforce: "pre",
configureServer(server) { devServer = server },
Expand All @@ -21,13 +21,13 @@ export function manifest(start: SolidStartOptions): PluginOption {
if (id === VIRTUAL_MODULES.getManifest) {
return this.environment.config.consumer === "client"
? this.resolve(
new URL("../server/manifest/client-manifest", import.meta.url)
.pathname,
)
new URL("../server/manifest/client-manifest", import.meta.url)
.pathname,
)
: this.resolve(
new URL("../server/manifest/ssr-manifest", import.meta.url)
.pathname,
);
new URL("../server/manifest/ssr-manifest", import.meta.url)
.pathname,
);
}
if (id === VIRTUAL_MODULES.middleware) {
if (start.middleware) return await this.resolve(start.middleware);
Expand All @@ -53,10 +53,10 @@ export function manifest(start: SolidStartOptions): PluginOption {
} else if (id === `\0${VIRTUAL_MODULES.middleware}`)
return "export default {};";
else if (id.startsWith("/@manifest")) {
if (this.environment.mode !== "dev") throw new Error("@manifest queries are only allowed in dev");
if (this.environment.mode !== "dev") throw new Error("@manifest queries are only allowed in dev");

const [path, query] = id.split("?");
const target = id.split("/")[2]!;
const target = id.split("/")[2]!;
const params = new URLSearchParams(query);
if (!path || !query) return;
if (path.endsWith("assets")) {
Expand Down
Loading