Skip to content

Use h3/generic for runtime agnostic methods#2126

Open
huseeiin wants to merge 2 commits intosolidjs:mainfrom
huseeiin:fix-cloudflare
Open

Use h3/generic for runtime agnostic methods#2126
huseeiin wants to merge 2 commits intosolidjs:mainfrom
huseeiin:fix-cloudflare

Conversation

@huseeiin
Copy link
Copy Markdown
Contributor

@huseeiin huseeiin commented Apr 3, 2026

now cloudflare works when not using nitro.
previously doing wrangler dev dist/server/entry-server.js (when using @cloudflare/vite-plugin, of course) the server would return a srvx NodeResponse instead of a standard Response which doesn't work.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit a29c2cb
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69d0278897a67b0007eb8184
😎 Deploy Preview https://deploy-preview-2126--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: a29c2cb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2126
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2126

commit: a29c2cb

@atilafassina atilafassina changed the title fix cloudflare Use h3/generic for runtime agnostic methods Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant