Skip to content

docs: fix "a accessor" → "an accessor" grammar typo#2680

Closed
Bojun-Vvibe wants to merge 1 commit intosolidjs:mainfrom
Bojun-Vvibe:agent/solidjs_solid-1776716066
Closed

docs: fix "a accessor" → "an accessor" grammar typo#2680
Bojun-Vvibe wants to merge 1 commit intosolidjs:mainfrom
Bojun-Vvibe:agent/solidjs_solid-1776716066

Conversation

@Bojun-Vvibe
Copy link
Copy Markdown

Repo: solidjs/solid (⭐ 31000)
Type: docs
Files changed: 2
Lines: +2/-2

What

Corrects the indefinite article before "accessor" in two places: the JSDoc @returns tag for the public children() API in packages/solid/src/reactive/signal.ts, and an inline code comment in packages/solid/README.md. Both read "a accessor" and should be "an accessor".

Why

The JSDoc string is surfaced in IDEs (VS Code hover/IntelliSense) for anyone consuming children(), and the README comment is quoted from Solid's canonical "getting started" Counter example — both are user-facing surfaces where a grammar slip reads as sloppy. No behavior change.

Testing

Visual diff only; no runtime or type changes. tsc output is unaffected since the edits are within comments.

Risk

Low — comment-only change to two files.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

⚠️ No Changeset found

Latest commit: 3d77f6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Bojun-Vvibe Bojun-Vvibe closed this by deleting the head repository Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant