docs: fix "a accessor" → "an accessor" grammar typo#2680
Closed
Bojun-Vvibe wants to merge 1 commit intosolidjs:mainfrom
Closed
docs: fix "a accessor" → "an accessor" grammar typo#2680Bojun-Vvibe wants to merge 1 commit intosolidjs:mainfrom
Bojun-Vvibe wants to merge 1 commit intosolidjs:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo: solidjs/solid (⭐ 31000)
Type: docs
Files changed: 2
Lines: +2/-2
What
Corrects the indefinite article before "accessor" in two places: the JSDoc
@returnstag for the publicchildren()API inpackages/solid/src/reactive/signal.ts, and an inline code comment inpackages/solid/README.md. Both read "a accessor" and should be "an accessor".Why
The JSDoc string is surfaced in IDEs (VS Code hover/IntelliSense) for anyone consuming
children(), and the README comment is quoted from Solid's canonical "getting started" Counter example — both are user-facing surfaces where a grammar slip reads as sloppy. No behavior change.Testing
Visual diff only; no runtime or type changes.
tscoutput is unaffected since the edits are within comments.Risk
Low — comment-only change to two files.