fix(portal): guard removeChild against externally cleared mount#2794
Open
tsushanth wants to merge 1 commit into
Open
fix(portal): guard removeChild against externally cleared mount#2794tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
If the portal mount node is cleared externally (e.g. via innerHTML = "") before Solid's cleanup runs, the onCleanup callback would throw a NotFoundError because the container is no longer a child of el. Guard the removeChild call with el.contains(container) so disposal is a no-op when the container has already been removed from the DOM. Fixes solidjs#2775
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2775
Disposing a Portal throws NotFoundError if the mount node is externally cleared before Solid's cleanup callbacks run. el.removeChild(container) fails because container is no longer a child of el.
The fix guards the call with el.contains(container) so cleanup is a no-op when the container has already been detached. Regression test added to portal.spec.tsx.