fix(reconcile): force replacement when nested value type changes between array and object#2796
Open
tsushanth wants to merge 1 commit into
Open
Conversation
…een array and object When a tracked store property holds an array and reconcile replaces it with a plain object (or vice versa), the previous code recursively called applyState on the same-typed proxy, leaving the signal node pointing at the old array-shaped wrapper even after STORE_VALUE was updated. Reading the property through a memo therefore still returned Array.isArray() === true for the new object value. The fix adds Array.isArray(previousValue) !== Array.isArray(nextValue) to the early-replacement guard in both applyStateFast and applyStateSlow so a type switch always forces the signal node to be rewritten with a fresh wrapped value rather than patched in place. Fixes solidjs#2774
🦋 Changeset detectedLatest commit: 1265634 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by 36.59%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | merge |
331.5 µs | 222.8 µs | +48.77% |
| ⚡ | omit |
215.7 µs | 172 µs | +25.4% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing tsushanth:fix/reconcile-array-object-type-mismatch (1265634) with next (a4ca10b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tracked store property holds an array and
reconcilereplaces it with a plain object (or vice versa), the previous code entered the object-merge loop and calledapplyStaterecursively on the existing array-shaped proxy. The in-place patch swappedSTORE_VALUEbut left the signal node pointing at the old wrapper, so a memo or effect reading that property continued to seeArray.isArray() === trueeven after the value became a plain object.The guard that already handles non-wrappable values, missing values, and key identity mismatches now also catches
Array.isArray(previousValue) !== Array.isArray(nextValue). When the structural type differs, the signal node is rewritten with a freshwrap(nextValue, target)call rather than delegating toapplyState, which correctly replaces the proxy for downstream subscribers.The same one-line guard is added to both
applyStateFastandapplyStateSlow.Fixes #2774