Admin UI fixes#176
Open
tvdeyen wants to merge 8 commits into
Open
Conversation
Not everybody uses the starter frontend.
Rails does not create a sprockets manifest anymore, but we still depend on it. Since rails commands do not work anymore, because sprockets raises an error if no `manifest.js` file is present we need to create it in order to be able to run `rails new`.
Solidus main already has a stores configuration tab.
This has not been updated in a long while. Although Solidus has its own Stores index this extenstion made some important aditions: 1. It allows to destroy stores 2. It adds mail from adress and code That qualifies this template override
Solidus has a form as well. Since this extension added a lot of fields, we update the override to the latest of Solidus 4.5
solidus_dev_support removed Rubocop and uses Standard for formatting rules.
Rails does not create a Sprockets manifest anymore. Need to create it before being able to run any rails commands.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #175
This extensions Admin UI has not been updated ever. Solidus has store admin templates included since forever.
Since this extension adds a lot of fields to the admin forms I kept them, but updated them to match the
current (4.5) Solidus backend UI.
Before
After